From nobody Fri Nov 11 01:25:29 2022 X-Original-To: virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4N7gxk0MQGz4f0rj for ; Fri, 11 Nov 2022 01:25:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4N7gxj580hz3HlD for ; Fri, 11 Nov 2022 01:25:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1668129929; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yhblji5DZ71nfnIUEZ4gPUigGBuJK7iewmDw/UTpvsc=; b=QXVZIjQcHbZ2KCRCmYZz5HFqL/HrpcrI/ki6GOyPBPv9CjbdcdSrAGB4EIaw96xT5ciFZ5 5XD1U6sHlYq9YcKGMTzPs6NMMe2qZA1u3rYyqmVQ7Nb2Z2YhdAjKjI0TvhDEP8NdObFgHL 0SJaUpNss36Tyzej6MmE/sSruXIdS2xlV7J+i9X+6BVq1kqYSMZ/UarJHvbWyZc32XBLOE 4gp5vdz3ta2fjJmmtCU8mms5IedtujS1lSoUF8C25hYoSfCKEa/xa02Lca1P6mrJ2bfd0Z n4a/TNm6FXwk/rgwBspBU67GUu3JxlgWrItte4TDqGBSWCVvMaHSNLngcl/bCA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1668129929; a=rsa-sha256; cv=none; b=RH5cGiXlqlT90YQlOZNmPEJr4fjEeCwn+0mpl5KaGNhXzQ5hxzUByNaSWFnimy3ZXHAjzd CO6oJRk4Ujs2uVOM94uaOj3y9hUVZL1r+ZmxoAzr38VRTFOiEC/5zUdjPqPiXAsasy384t 0k3Jxb70oZ1WfzUYJgZ+vbOVcKVDwlAj6Vt1w0mMV4UnYsufL87dIj9Udkk/SruJSooXGm OkEeRubzxNYcQXhUcqsIQKvWzmp597BUH9t5lWB31YX8x8yc6/F9Wu5GMv/k7k8SyWxewD e84SlhB8GJXtbWH8ZeAmAfsbpNI75LQElqJAzFEVpiCwbujEibny9Ldl+BKoTQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4N7gxj4FXFzNg7 for ; Fri, 11 Nov 2022 01:25:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 2AB1PTW1023552 for ; Fri, 11 Nov 2022 01:25:29 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 2AB1PTi0023551 for virtualization@FreeBSD.org; Fri, 11 Nov 2022 01:25:29 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: virtualization@FreeBSD.org Subject: [Bug 264521] bhyve: pci_vtscsi_request_handle() can read beyond allocated heap object Date: Fri, 11 Nov 2022 01:25:29 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bhyve X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: needs-patch, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: jhb@FreeBSD.org X-Bugzilla-Flags: mfc-stable13? mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D264521 --- Comment #5 from commit-hook@FreeBSD.org --- A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Db37b564ecf0a2e079acbd1866337a5c6e= d739d73 commit b37b564ecf0a2e079acbd1866337a5c6ed739d73 Author: John Baldwin AuthorDate: 2022-08-29 22:36:11 +0000 Commit: John Baldwin CommitDate: 2022-11-11 01:10:18 +0000 bhyve virtio-scsi: Avoid out of bounds accesses to guest requests. - Ignore I/O requests with insufficiently sized input or output buffers (those not containing compete request headers). - Ignore control requests with improperly sized buffers. - While here, explicitly zero the output header of an I/O request to avoid leaking malloc garbage from the host if the header is not fully populated. PR: 264521 Reported by: Robert Morris Reviewed by: mav, emaste MFC after: 1 week Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D36271 (cherry picked from commit bb31aee26bd13307d97c5d5bf2b10bf05bdc18fd) usr.sbin/bhyve/pci_virtio_scsi.c | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) --=20 You are receiving this mail because: You are on the CC list for the bug.=