From nobody Sun Mar 20 22:34:15 2022 X-Original-To: freebsd-virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id AE5E41A25C62 for ; Sun, 20 Mar 2022 22:34:24 +0000 (UTC) (envelope-from bakul@iitbombay.org) Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KMCGl4RxXz4SJy for ; Sun, 20 Mar 2022 22:34:23 +0000 (UTC) (envelope-from bakul@iitbombay.org) Received: by mail-qk1-x72e.google.com with SMTP id h196so10564965qke.12 for ; Sun, 20 Mar 2022 15:34:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iitbombay-org.20210112.gappssmtp.com; s=20210112; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=c032sKPn4Xs2b/glocyL21xp0TjWG8inGQG8UqAYvKM=; b=juhiiixDMgg040HeLPdVtMRj9gqO2tH/gB3IytnjIPOVE+EQratbYbcD3fCeCykL1h IgFsFc/R8gogYs/QAIps8cic6QVL1t2hBFpqss59a3lU9hcrPv4buSvUqdKxl0NGO/eA 6w7at+GaB+vGEJ7dSHVGSVvWl9ytmdHzyvU8BNqTNWVbHMG4X4EDr7aglWVol/WDu397 5sbS16J+HI6RGys+8LjQAfA+o30uXU6kRCyUGiNGDM+s7AejuiUh1nKnniXt7/d3Uz72 V/6ahMhueddRnQoNriS1ZUlhp7uUyl7ASUcSURy0/bfE04ZdU1OGfSyZuPTCzlYj7brg fEow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=c032sKPn4Xs2b/glocyL21xp0TjWG8inGQG8UqAYvKM=; b=Qcuqy0Em0iL/e/f6s5ig8zxKv8RcPlBIIXLsvkNVJ7V00ZzDlMt0GGcu+EDogOOvJ0 BDWLjgQf8PHkXNqynT3gBlzjzXPYXuW7MmyvjXJFT0zwoqNtvFafru7+b/juhi/TI5JL K2EwaqZpxVYwESpt4Ff8BBz3Lf6nNlPnijXBbvz7+vda7RxDRsEL18a2pg6BTYt3eAiY Et1nl0Uf37NvRafGwJTzf5/TlRnigOByE6R5dOz/UIDJyea48Lveclb1358b3XDM1DLG y1rCfoU2tfsCD8yjFtwBq6nlKxtQCFDzFtpaGUhSsUdb+XhjuyBd0Yo1MTwSETgtnHhA w6Nw== X-Gm-Message-State: AOAM530+uVpeeo8GFJIuJTQquZMp1SHAelJdVsM92T5nBOqcXmPSkO4F SfVnAU2S2h8a5kerTTALZbslAg== X-Google-Smtp-Source: ABdhPJzTaG8NsSU/3SuXnDkRRQAAbcyADU82GrnedRWly83MGO49KpYXEhBpOyesYQFIWTm1EJ1e5w== X-Received: by 2002:ae9:efd5:0:b0:67e:69ef:84eb with SMTP id d204-20020ae9efd5000000b0067e69ef84ebmr6062736qkg.212.1647815657099; Sun, 20 Mar 2022 15:34:17 -0700 (PDT) Received: from smtpclient.apple (107-215-223-229.lightspeed.sntcca.sbcglobal.net. [107.215.223.229]) by smtp.gmail.com with ESMTPSA id d82-20020a376855000000b0067dacb03b6esm7064091qkc.130.2022.03.20.15.34.16 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 20 Mar 2022 15:34:16 -0700 (PDT) Content-Type: text/plain; charset=us-ascii List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\)) Subject: Re: bhyve NVMe 1.4 support From: Bakul Shah In-Reply-To: Date: Sun, 20 Mar 2022 15:34:15 -0700 Cc: Chuck Tuffli , jason@tubnor.net, FreeBSD virtualization Content-Transfer-Encoding: 7bit Message-Id: <5CBC2D64-9CAC-4B88-97AA-D9906CE0517E@iitbombay.org> References: <00bf01d80104$e6ba5de0$b42f19a0$@tubnor.net> <082b01d80697$64e95030$2ebbf090$@tubnor.net> To: Mario Marietto X-Mailer: Apple Mail (2.3696.80.82.1.1) X-Rspamd-Queue-Id: 4KMCGl4RxXz4SJy X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=pass header.d=iitbombay-org.20210112.gappssmtp.com header.s=20210112 header.b=juhiiixD; dmarc=none; spf=pass (mx1.freebsd.org: domain of bakul@iitbombay.org designates 2607:f8b0:4864:20::72e as permitted sender) smtp.mailfrom=bakul@iitbombay.org X-Spamd-Result: default: False [1.00 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[iitbombay-org.20210112.gappssmtp.com:+]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[iitbombay-org.20210112.gappssmtp.com:s=20210112]; FREEFALL_USER(0.00)[bakul]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; NEURAL_SPAM_SHORT(1.00)[0.996]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-virtualization@freebsd.org]; DMARC_NA(0.00)[iitbombay.org]; NEURAL_SPAM_MEDIUM(1.00)[1.000]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::72e:from]; MLMMJ_DEST(0.00)[freebsd-virtualization]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On Mar 20, 2022, at 3:11 PM, Mario Marietto wrote: > > -s 2,nvme,/dev/nvd0 \ AIUI, this 'nvme' means bhyve will *emulate* an NVME device and it will treat whatever is given to it (/dev/nvd0) as just dumb storage. It doesn't care if /dev/nvd0 is an NVME device. So commands such as nvmecontrol identify etc. in the *guest* won't be passed through to /dev/nvd0 through to it. If you run nvmecontrol identify under ktrace in the guest, you will see something like 3657 nvmecontrol NAMI "/dev/nvme0ns1" 3657 nvmecontrol RET openat 3 3657 nvmecontrol CALL ioctl(0x3,NVME_GET_NSID,0x1245f31731a8) 3657 nvmecontrol RET ioctl 0 3657 nvmecontrol CALL close(0x3) 3657 nvmecontrol RET close 0 3657 nvmecontrol CALL openat(AT_FDCWD,0x1245f3173260,0) 3657 nvmecontrol NAMI "/dev/nvme0" 3657 nvmecontrol RET openat 3 3657 nvmecontrol CALL ioctl(0x3,NVME_PASSTHROUGH_CMD,0x1245f3173250) 3657 nvmecontrol RET ioctl 0 3657 nvmecontrol CALL close(0x3) These ioctls will *not* be passed on the real /dev/nvd0 in the host so they are *not* going to return the same information. If you want to talk to the real nvme device from a guest, you have to use a passthrough device. Though I don't know how well this works (or if at all).