From nobody Wed Jun 08 14:49:25 2022 X-Original-To: virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 95207852592 for ; Wed, 8 Jun 2022 14:49:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LJ99L18vYz4V86 for ; Wed, 8 Jun 2022 14:49:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 041C111CA3 for ; Wed, 8 Jun 2022 14:49:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 258EnPkR057763 for ; Wed, 8 Jun 2022 14:49:25 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 258EnPkA057762 for virtualization@FreeBSD.org; Wed, 8 Jun 2022 14:49:25 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: virtualization@FreeBSD.org Subject: [Bug 264548] bhyve's nvme_opc_dataset_mgmt() can free() uninitialized pointer Date: Wed, 08 Jun 2022 14:49:25 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bhyve X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: rtm@lcs.mit.edu X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: virtualization@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1654699766; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FjE7ZPKLssB8iywcZpjyvnwI1rhxdDEk6CHR1SoLF7E=; b=cGCqkwlCWfT6kVTB/N8Tfje+LiFiC7/7ZuU8+jS0Py5Ag3Sbbc5vpZtJuyXEfM0Xw7pLH1 FmwGRrYtxl+z2F6X786w8e8x1W4IFeCWmQsPKLxkP82xj07vm/5F9/PiCwm3mc3qATeARo z2FVC741Is1UGmDNJkTd4sIXKxsazs346xBnmdULM0cr939gg9/J4rzz4dExicoXZZtxOI tE8smlSKTAnpRVTLMbU6IPTKm7ezYARBFsnMWyKlzSXMOTgARxdE4G5S4ekvsO7zx6INVL GsG4sCxw2ybMZVCzXJAl45pW/JtB1XhP8cazz/DuV8s4Ho/8gy0PVA3Aidq3KQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1654699766; a=rsa-sha256; cv=none; b=f4w5N62CbwGnWW5ll947gvlEdBtoKf+e7tdeJh6oqB5atJSPG583EZF6sSRdTV4XSJSZte lRhq+7xhJ2CCyJ1D8nFGjbT3ayrml3LKGtzsFNRTQ4KyzbR/YC8bdQY/BxAfvU0k/ZTO0O D/B+feKuLVgHJbMsUcx2ONknoGB4JK6wki+NYf0lP7b55RbmUJZkwzMpAI4ex2/Yxrg/p8 mwTixmBLOZCac50czmijTk3dlUheIEHEFqNffBtuAvZTn20i4UAmqabmuI9uEZy1QIqRHF fue4qcJLGqljhXRn52z7ColjHTZ1q9/dFflLhplGEghZCIgzlKHJhCFBV+gylA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D264548 Bug ID: 264548 Summary: bhyve's nvme_opc_dataset_mgmt() can free() uninitialized pointer Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: bhyve Assignee: virtualization@FreeBSD.org Reporter: rtm@lcs.mit.edu Bhyve's nvme_opc_dataset_mgmt() can free(range) before initializing it: struct nvme_dsm_range *range; ...; if ((sc->ctrldata.oncs & NVME_ONCS_DSM) =3D=3D 0) { pci_nvme_status_genc(status, NVME_SC_INVALID_OPCODE); goto out; } ...; range =3D calloc(1, NVME_MAX_DSM_TRIM); ...; out: free(range); A guest can cause this to happen by ringing the doorbell of a submission queue with an entry with cmd->opc NVME_OPC_DATASET_MANAGEMENT. --=20 You are receiving this mail because: You are the assignee for the bug.=