From nobody Tue Jan 11 03:00:30 2022 X-Original-To: freebsd-virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 84D4819401DC for ; Tue, 11 Jan 2022 03:00:44 +0000 (UTC) (envelope-from jason@tubnor.net) Received: from mail.tubnor.net (mail.tubnor.net [103.236.162.16]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA512) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4JXwRv5g0wz4cYk for ; Tue, 11 Jan 2022 03:00:43 +0000 (UTC) (envelope-from jason@tubnor.net) Received: from THEMASTER (119-18-29-78.77121d.mel.static.aussiebb.net [119.18.29.78]) by mel01.ar18.net (OpenSMTPD) with ESMTPSA id 6d8ca2b6 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Tue, 11 Jan 2022 14:00:30 +1100 (AEDT) From: To: "'Chuck Tuffli'" Cc: "'FreeBSD virtualization'" References: <00bf01d80104$e6ba5de0$b42f19a0$@tubnor.net> In-Reply-To: Subject: RE: bhyve NVMe 1.4 support Date: Tue, 11 Jan 2022 14:00:30 +1100 Message-ID: <082b01d80697$64e95030$2ebbf090$@tubnor.net> List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQI3pyxa47RFMbeIje9qANVUNy8ucQHoLJRiAYLQ7JUDQrq7UatocMhg Content-Language: en-au X-Rspamd-Queue-Id: 4JXwRv5g0wz4cYk X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N > -----Original Message----- > From: Chuck Tuffli > Sent: Tuesday, 11 January 2022 10:58 AM > To: jason@tubnor.net > Cc: FreeBSD virtualization > Subject: Re: bhyve NVMe 1.4 support >=20 > On Wed, Jan 5, 2022 at 4:33 PM Chuck Tuffli wrote: > > > > On Mon, Jan 3, 2022 at 4:49 PM wrote: > > > > > > Hi Chuck, > > > > > > Testing on 14.0-CURRENT shows the following: > > > > > > OpenBSD 6.9 - NVMe read/write OK > > > Windows 10 - NVMe read OK, write FAIL Windows Server 2022 - NVMe > > > read OK, write FAIL Alma Linux 8.5 - NVMe read OK, write FAIL. > > > > Thanks for the report, Jason. I have Alma 8.5 installed and am = investigating. >=20 > OK, I found and fixed the regression. New version of the file in the = same > place is up for folks who are interested. >=20 > --chuck This version looks good. No regression on the following guest platforms = under 14.0-CURRENT: OpenBSD 6.9 - NVMe read/write OK Windows 10 - NVMe read/write OK Windows Server 2022 - NVMe read/write OK Alma Linux 8.5 - NVMe read/write OK FreeBSD 13.0 - NVMe read/write OK From a storage presentation layer in a production perspective, I can't = find any issues with the proposed update to pci_nvme.c Some of our tests included: The removal and addition of partitions on the NVMe presentation layer Installation of all the operating system listed above Where supported by the guest operating system, the TRIM command executed = on the presentation layer and guest rebooted to ensure no data = corruption was caused by TRIM Cheers, Jason.