[Bug 252445] panics on ESXi triggered by update making devd(8) to load vmci(4) module
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sat, 09 Oct 2021 21:30:23 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252445
--- Comment #20 from commit-hook@FreeBSD.org ---
A commit in branch main references this bug:
URL:
https://cgit.FreeBSD.org/src/commit/?id=0f14bcbe384091c729464cb770372aeb79061070
commit 0f14bcbe384091c729464cb770372aeb79061070
Author: Mark Peek <mp@FreeBSD.org>
AuthorDate: 2021-10-09 21:21:16 +0000
Commit: Mark Peek <mp@FreeBSD.org>
CommitDate: 2021-10-09 21:21:16 +0000
vmci: fix panic due to freeing unallocated resources
Summary:
An error mapping PCI resources results in a panic due to unallocated
resources being freed up. This change puts the appropriate checks in
place to prevent the panic.
PR: 252445
Reported by: Marek Zarychta <zarychtam@plan-b.pwste.edu.pl>
Tested by: marcus
MFC after: 1 week
Sponsored by: VMware
Test Plan:
Along with user testing, also simulated error by inserting a ENXIO
return in vmci_map_bars().
Reviewed by: marcus
Subscribers: imp
Differential Revision: https://reviews.freebsd.org/D32016
sys/dev/vmware/vmci/vmci.c | 9 ++++---
sys/dev/vmware/vmci/vmci_event.c | 3 +++
sys/dev/vmware/vmci/vmci_kernel_if.c | 48 ++++++++++++++++++++++++++++++++++-
sys/dev/vmware/vmci/vmci_kernel_if.h | 2 ++
sys/dev/vmware/vmci/vmci_queue_pair.c | 3 +++
5 files changed, 61 insertions(+), 4 deletions(-)
--
You are receiving this mail because:
You are the assignee for the bug.