From nobody Thu Mar 10 07:49:35 2022 X-Original-To: freebsd-usb@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 1E63719FA556 for ; Thu, 10 Mar 2022 07:49:50 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [IPv6:2a01:4f8:c17:6c4b::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4KDh6j3PKJz4T7P for ; Thu, 10 Mar 2022 07:49:49 +0000 (UTC) (envelope-from hps@selasky.org) Received: from [10.36.2.165] (unknown [178.17.145.105]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 1378226062A; Thu, 10 Mar 2022 08:49:48 +0100 (CET) Message-ID: Date: Thu, 10 Mar 2022 08:49:35 +0100 List-Id: FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-usb List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-usb@freebsd.org X-BeenThere: freebsd-usb@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: Understanding USB callback + assertion panic Content-Language: en-US To: Farhan Khan , Daniel O'Connor Cc: freebsd-usb@freebsd.org References: <7abd641a74526552a8cc1692f7453cb3c1279034.camel@farhan.codes> <1646869058201.32255222.1343660178@farhan.codes> From: Hans Petter Selasky In-Reply-To: <1646869058201.32255222.1343660178@farhan.codes> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4KDh6j3PKJz4T7P X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of hps@selasky.org designates 2a01:4f8:c17:6c4b::2 as permitted sender) smtp.mailfrom=hps@selasky.org X-Spamd-Result: default: False [-2.32 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+a:mail.turbocat.net:c]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[selasky.org]; NEURAL_HAM_MEDIUM(-0.08)[-0.085]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.94)[-0.940]; MLMMJ_DEST(0.00)[freebsd-usb]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/32, country:DE]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On 3/10/22 00:39, Farhan Khan wrote: > On Wednesday 09 March 2022 16:42:58 PM (-05:00), Farhan Khan wrote: > > > --------- > > error = usbd_transfer_setup(uaa->device, &iface_index, usc->usc_xfer, > > athn_config_common, ATHN_N_TRANSFERS, usc, &sc->sc_mtx); > > ATHN_LOCK(sc); > > usbd_transfer_start(usc->usc_xfer[ATHN_BULK_TX_DATA]); > > ATHN_UNLOCK(sc); > > --------- > > > > Considering this is quite similar to how other drivers do this, what > > might I be doing wrong? > > > > The mistake was on my end! My ATHN_LOCK code was incorrect and was not > actually locking the mutex. The issue was resolved and it works. > Thank you! I'm learning and making a lot of mistakes along the way. > Good to hear :-) --HPS