From nobody Mon Jan 31 08:38:13 2022 X-Original-To: usb@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 72C041981BF2 for ; Mon, 31 Jan 2022 08:38:32 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [IPv6:2a01:4f8:c17:6c4b::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4JnM0R3bCxz3FFR for ; Mon, 31 Jan 2022 08:38:31 +0000 (UTC) (envelope-from hps@selasky.org) Received: from [10.36.2.165] (unknown [178.17.145.105]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id EF7442602CC; Mon, 31 Jan 2022 09:38:22 +0100 (CET) Message-ID: Date: Mon, 31 Jan 2022 09:38:13 +0100 List-Id: FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-usb List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-usb@freebsd.org X-BeenThere: freebsd-usb@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: xhci Panic patch Content-Language: en-US To: Nitin Gupta , usb@freebsd.org References: From: Hans Petter Selasky In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4JnM0R3bCxz3FFR X-Spamd-Bar: ++ Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of hps@selasky.org designates 2a01:4f8:c17:6c4b::2 as permitted sender) smtp.mailfrom=hps@selasky.org X-Spamd-Result: default: False [2.68 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+a:mail.turbocat.net]; NEURAL_SPAM_SHORT(0.99)[0.993]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[selasky.org]; NEURAL_SPAM_MEDIUM(0.99)[0.988]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_SPAM_LONG(1.00)[0.999]; MLMMJ_DEST(0.00)[usb]; FREEMAIL_TO(0.00)[gmail.com,freebsd.org]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/32, country:DE]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On 1/31/22 08:32, Nitin Gupta wrote: > Dear Group Member > > I came across the kernel Panic in xhci module for some of my > development activities .Issue is very random and looks like td is NULL .. > Please Review the below patch and let me know your thoughts > Can you show the panic backtrace? Which version of FreeBSD is this? > pepext = &sc->sc_hw.devs[index].endp[epno]; ^^^ none of these structures can be NULL, when the "sc" is non-null. Your patch doesn't look right. --HPS > > index e88a827..a6ce227 100644 > --- a/sys/dev/usb/controller/xhci.c > +++ b/sys/dev/usb/controller/xhci.c > @@ -886,7 +886,7 @@ xhci_skip_transfer(struct usb_xfer *xfer) > static void > xhci_check_transfer(struct xhci_softc *sc, struct xhci_trb *trb) > { > - struct xhci_endpoint_ext *pepext; > + struct xhci_endpoint_ext *pepext = NULL; > int64_t offset; > uint64_t td_event; > uint32_t temp; > @@ -929,6 +929,10 @@ xhci_check_transfer(struct xhci_softc *sc, struct > xhci_trb *trb > ) > > pepext = &sc->sc_hw.devs[index].endp[epno]; > > + if (pepext == NULL) { > + DPRINTF("pepext is Null\n"); > + return; > + } > if (pepext->trb_ep_mode != USB_EP_MODE_STREAMS) { > stream_id = 0; > @@ -940,8 +944,8 @@ xhci_check_transfer(struct xhci_softc *sc, struct > xhci_trb *trb) > > /* try to find the USB transfer that generated the event */ > for (i = 0; i != (XHCI_MAX_TRANSFERS - 1); i++) { > - struct usb_xfer *xfer; > - struct xhci_td *td; > + struct usb_xfer *xfer = NULL; > + struct xhci_td *td = NULL; > > xfer = pepext->xfer[i + (XHCI_MAX_TRANSFERS * stream_id)]; > if (xfer == NULL) > @@ -949,6 +953,9 @@ xhci_check_transfer(struct xhci_softc *sc, struct > xhci_trb *trb) > > td = xfer->td_transfer_cache; > > > > > Regards > Nitin >