From nobody Mon Apr 18 19:47:03 2022 X-Original-To: freebsd-usb@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 5E6EB11E3441 for ; Mon, 18 Apr 2022 19:47:12 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [88.99.82.50]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4KhyBR4cZ9z4hWB; Mon, 18 Apr 2022 19:47:11 +0000 (UTC) (envelope-from hps@selasky.org) Received: from [10.36.2.165] (unknown [176.74.213.87]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 79217260074; Mon, 18 Apr 2022 21:47:03 +0200 (CEST) Content-Type: multipart/mixed; boundary="------------b1O056sgZ9Ha9OnQoYpLxE0n" Message-ID: <8f51424d-7d1a-9f0a-a0ba-27b02cab0942@selasky.org> Date: Mon, 18 Apr 2022 21:47:03 +0200 List-Id: FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-usb List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-usb@freebsd.org X-BeenThere: freebsd-usb@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: xhci data toggle out of sync Content-Language: en-US To: Mahesh Vardhamanaiah , "freebsd-usb@freebsd.org" Cc: Steve Kiernan , Justin Hibbits , Kumara N Babu , Kamal Prasad , Kristof Provost , "Bjoern A. Zeeb" References: <61bc4594-f2d3-17c4-42b5-0297ffd78fa3@selasky.org> From: Hans Petter Selasky In-Reply-To: X-Rspamd-Queue-Id: 4KhyBR4cZ9z4hWB X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of hps@selasky.org designates 88.99.82.50 as permitted sender) smtp.mailfrom=hps@selasky.org X-Spamd-Result: default: False [-2.20 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+a:mail.turbocat.net:c]; MID_RHS_MATCH_FROM(0.00)[]; MIME_GOOD(-0.10)[multipart/mixed,text/plain,text/x-patch]; HAS_ATTACHMENT(0.00)[]; DMARC_NA(0.00)[selasky.org]; MIME_BASE64_TEXT_BOGUS(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-1.00)[-0.999]; MIME_BASE64_TEXT(0.10)[]; RCPT_COUNT_SEVEN(0.00)[8]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; MLMMJ_DEST(0.00)[freebsd-usb]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:+]; ASN(0.00)[asn:24940, ipnet:88.99.0.0/16, country:DE]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N This is a multi-part message in MIME format. --------------b1O056sgZ9Ha9OnQoYpLxE0n Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, I think I see what is going on there. I believe this commit is a regression after r365239, that the XHCI driver only resets the data toggle when a STALL PID or USB error is received! But that is not the case for the BULK OUT endpoint, in your traces, because USB mass storage has two endpoints. https://svnweb.freebsd.org/changeset/base/365239 Can you try the attached patch instead of reverting that commit and see if the XHCI now sends a DATA0, as expected? Bjoern and Kristof, can you also test this patch? --HPS --------------b1O056sgZ9Ha9OnQoYpLxE0n Content-Type: text/x-patch; charset=UTF-8; name="a.diff" Content-Disposition: attachment; filename="a.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL3N5cy9kZXYvdXNiL2NvbnRyb2xsZXIveGhjaS5jIGIvc3lzL2Rldi91 c2IvY29udHJvbGxlci94aGNpLmMKaW5kZXggZjk1OTk2YjdhYjMuLmViODgxNDBjZjU1IDEw MDY0NAotLS0gYS9zeXMvZGV2L3VzYi9jb250cm9sbGVyL3hoY2kuYworKysgYi9zeXMvZGV2 L3VzYi9jb250cm9sbGVyL3hoY2kuYwpAQCAtMzgyNSw2ICszODI1LDEzIEBAIHhoY2lfY29u ZmlndXJlX3Jlc2V0X2VuZHBvaW50KHN0cnVjdCB1c2JfeGZlciAqeGZlcikKIAkJZXJyID0g eGhjaV9jbWRfc3RvcF9lcChzYywgMCwgZXBubywgaW5kZXgpOwogCQlpZiAoZXJyICE9IDAp CiAJCQlEUFJJTlRGKCJDb3VsZCBub3Qgc3RvcCBlbmRwb2ludCAldVxuIiwgZXBubyk7CisJ CS8qCisJCSAqIE5lZWQgdG8gcmVzZXQgdGhlIGRhdGEgdG9nZ2xlLCBiZWNhdXNlIHN0b3AK KwkJICogZW5kcG9pbnQgZG9lc24ndCBkbyB0aGF0OgorCQkgKi8KKwkJZXJyID0geGhjaV9j bWRfcmVzZXRfZXAoc2MsIDAsIGVwbm8sIGluZGV4KTsKKwkJaWYgKGVyciAhPSAwKQorCQkJ RFBSSU5URigiQ291bGQgbm90IHJlc2V0IGVuZHBvaW50ICV1XG4iLCBlcG5vKTsKIAkJYnJl YWs7CiAJfQogCg== --------------b1O056sgZ9Ha9OnQoYpLxE0n--