Re: Finished books/arch-handbook/driverbasics in Spanish

On Thu, May 19, 2022 at 10:52 AM Sergio Carlavilla
<carlavilla@freebsd.org> wrote:
>
> On Thu, 19 May 2022 at 09:54, Rodrigo G. López <rodrigosloop@gmail.com> wrote:
>>
>> Hi!
>>
>> just wanted to ping so it's not forgotten.
>> I would like to close this one down before I continue with another component—mostly to avoid repeating potential mistakes.
>>
>>
>> Cheers!
>>
>> -rodri
>>
>> On Mon, May 16, 2022, 9:58 PM Sergio Carlavilla <carlavilla@freebsd.org> wrote:
>>>
>>> On Mon, 16 May 2022 at 21:56, Rodrigo G. López <rodrigosloop@gmail.com> wrote:
>>>>
>>>> Hi!
>>>>
>>>> I just finished translating one of the components/documents.
>>>> If any of you from the Spanish team—I only know Fernando
>>>> atm—could review it, I'd appreciate it.
>>>>
>>>> After the reviewing and—hopefully minimal—editing, what
>>>> would be the next step?
>>>>
>>>>
>>>> Best,
>>>>
>>>> -rodri
>>>>
>>> Hi Rodrigo,
>>>
>>> Thanks for that!
>>> I’ll take a look tomorrow.
>>> If the review is in good condition we can commit it to the repository.
>>>
>>> Bye and thanks!
>
> Hi,
>
> I was so busy this week, I’ll try to take a look this night (Spain time).
>
> Sorry for the delay.
>
> Bye and thanks for your work!!

Hi,

First of all, great work Rodrigo!

A couple of issues:

Invalid po file
documentation/content/es/books/arch-handbook/driverbasics/_index.po:
documentation/content/es/books/arch-handbook/driverbasics/_index.po:254:
'msgid' and 'msgstr' entries do not both begin with '\n'
msgfmt: found 1 fatal error

It looks like there was a spurious \n in a msgstr. No big deal.

Now, when trying to translate:

Discard the translation of
documentation/content/en/books/arch-handbook/isa/_index.adoc (only
0.26% translated; need 80%).

There is a minimum percentage of strings that need to be translated.
It is 80% currently although it can be modified locally. I went to
Weblate and saw the issue: code too must be either translated or
copied, otherwise, those msgids are left as untranslated. The way I do
it is:

* Copy the original text (Ctrl-C, Ctrl-V or by using the copy button
at the right of the text)
* Unclick the "Needs editing" checkbox (I know I want the code verbatim)
* Click "Save and continue"
* Click in "Dismiss" at the right of the page when Weblate complains
that the original text and the translated text are the same
* Click "Save and continue" again

I did that for driverbasiscs and now it looks clean. I also changed a
couple of small things. They have a comment associated in case you
want to have a look at them if you want to discuss them.

Thanks again for your work. It is much appreciated :-)