[Bug 257829] lldb crashes with asio acceptor::accept

From: <bugzilla-noreply_at_freebsd.org>
Date: Mon, 16 Aug 2021 17:02:18 +0000
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=257829

--- Comment #3 from commit-hook_at_FreeBSD.org ---
A commit in branch main references this bug:

URL:
https://cgit.FreeBSD.org/src/commit/?id=c1a540709a83f810aa47380b946552ab20020374

commit c1a540709a83f810aa47380b946552ab20020374
Author:     Dimitry Andric <dim_at_FreeBSD.org>
AuthorDate: 2021-08-16 16:56:41 +0000
Commit:     Dimitry Andric <dim_at_FreeBSD.org>
CommitDate: 2021-08-16 16:57:24 +0000

    Apply upstream lldb fix for unhandled Error causing abort

    Merge commit 5033f0793fe6 from llvm git (by Dimitry Andric):

      [lldb] Avoid unhandled Error in TypeSystemMap::GetTypeSystemForLanguage

      When assertions are turned off, the `llvm::Error` value created at the
      start of this function is overwritten using the move-assignment
      operator, but the success value is never checked. Whenever a TypeSystem
      cannot be found or created, this can lead to lldb core dumping with:

          Program aborted due to an unhandled Error:
          Error value was Success. (Note: Success values must still be checked
prior to being destroyed).

      Fix this by not creating a `llvm::Error` value in advance, and directly
      returning the result of `llvm::make_error` instead, whenever an error is
      encountered.

      See also: <https://bugs.freebsd.org/253881> and
      <https://bugs.freebsd.org/257829>.

      Reviewed By: teemperor

      Differential Revision: https://reviews.llvm.org/D108088

    Reported by:    dmgk, ota_at_j.email.ne.jp
    PR:             253881, 257829
    MFC after:      3 days

 .../llvm-project/lldb/source/Symbol/TypeSystem.cpp | 90 +++++++++-------------
 1 file changed, 38 insertions(+), 52 deletions(-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
Received on Mon Aug 16 2021 - 17:02:18 UTC

Original text of this message