[Bug 260547] sys.netmap.ctrl-api-test.main fails in CI

From: <bugzilla-noreply_at_freebsd.org>
Date: Tue, 21 Mar 2023 23:28:09 UTC

--- Comment #10 from commit-hook@FreeBSD.org ---
A commit in branch main references this bug:


commit e2a431a0ffb6894220bdf5d8fc2ca2d0ca316e85
Author:     Vincenzo Maffione <vmaffione@FreeBSD.org>
AuthorDate: 2023-03-21 23:23:18 +0000
Commit:     Vincenzo Maffione <vmaffione@FreeBSD.org>
CommitDate: 2023-03-21 23:23:18 +0000

    netmap: fix copyin/copyout of nmreq options list

    The previous code unsuccesfully attempted to report a precise error for
    each option in the user list. Moreover, commit 253b2ec199b broke some
    ctrl-api-test (see

    With this patch we bail out as soon as an unrecoverable error is detected
    we properly check for copy boundaries. EOPNOTSUPP no longer immediately
    returns an error, so that any other option in the list may be examined
    by the caller code and a precise report of the (un)supported options can
    be returned to the user.

    With this patch, all ctrl-api-test unit tests pass again.

    PR:                     260547
    Submitted by:           giuseppe.lettieri@unipi.it
    Reviewed by:            vmaffione
    MFC after:              14 days

 sys/dev/netmap/netmap.c          | 69 ++++++++++++++++++++++++----------------
 tests/sys/netmap/ctrl-api-test.c | 23 ++++++++++++--
 2 files changed, 63 insertions(+), 29 deletions(-)

You are receiving this mail because:
You are the assignee for the bug.