[Bug 204506] bsdinstall(8) umount target should be able to unmount zfs filesystems

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204506

Jonathan Reynolds <jreynolds1729@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jreynolds1729@gmail.com

--- Comment #7 from Jonathan Reynolds <jreynolds1729@gmail.com> ---
This still happens on 14-CURRENT.


The issue:

/usr/libexec/bsdinstall/umount fails if fstab is emtpty, which happens with ZFS
+ BIOS boot.
Two dialog box displaying /tmp/bsdinstall_log will be shown in succession (user
 input required).
The installation itself does succeed.

Simple fix (main 9a49a3792940497ddf4657f6e5be56d8ef881edc):

--- usr.sbin/bsdinstall/scripts/umount.orig     2023-06-01 18:17:39.482944000
+0200
+++ usr.sbin/bsdinstall/scripts/umount  2023-06-01 18:18:20.275423000 +0200
@@ -46,6 +46,6 @@
 }' > $TMP_FSTAB

 umount $BSDINSTALL_CHROOT/dev 2>/dev/null
-if [ -n "$TMP_FSTAB" ]; then
+if [ -n "$TMP_FSTAB" -a -s "$TMP_FSTAB" ]; then
        umount -F $TMP_FSTAB -a 2>/dev/null
 fi


Note:

The described issue does not happen if $debugFile is prepended with a plus `+'
sign.

if $debugFile is prepended with a `+' in /etc/rc.local and the `+' sign is
removed in /etc/installerconfig, the script will show one dialog box displaying
/tmp/bsdinstall_log and an other showing success/reboot.

-- 
You are receiving this mail because:
You are the assignee for the bug.