From nobody Tue Jan 09 17:58:09 2024 X-Original-To: standards@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T8dvP4sZMz564dn for ; Tue, 9 Jan 2024 17:58:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T8dvP3Jx3z4PbJ for ; Tue, 9 Jan 2024 17:58:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704823089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sl0XMh26Nju0WNtbR63INHEzP6beMbXVVstlaxXX+AY=; b=FA+KgvQB8/yonayaDWMzfi6OrgdmRGA+n3kTY8+Gk+ye1TNmg7rY1psa3jimJpl3k3f6k0 T1KJirC387mioaSxce+ms2a7zw9snXjHSONJeVVfgDLPzVw9u1Jz5eO1Du9oZv1KAgo1TL kMlW3dL5iulW7BN9PuyC416lxGZj3/9gAya7YjKbiBhb/bTD2pzREqlRNUgKEZ6PZlyydS am9dbQ4fmKoApxFTVsPcvce5/XzlTO/BkH7wBl+NYXcIdtTcgJZC/0NU8DWR4SPeIs6tNc daSY/L26eGhz3NifQBLKyqRIVatgrxt72ShXRCsIFXwUS5w6agWqZVX87Y86kg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704823089; a=rsa-sha256; cv=none; b=cfcBUmeQxoYvz3i6MaoEkpAqsi7OW11fq99CqMIB7QPSGabnxG2IFNjFkFiI0Z9tBUvVbl e8Fgl4VYJCNd+zghIwR0nHigN6hsoui8uleEt43usaI1N1LU6jNMykqOfNLlLwQJJfxP8e hdsk7F8lhYgd0foZjrG1vFoOlTgJPxMKsPGp67oPjXH9fjDN0R5yAzjVdqHZMZdq2yxcOv dGvyjCPR5T5f7SQdjbeBGw0z+EPJ1XCLPRCyEkwxu1S/nfFWFaPyqWFpo9Dzk/yLMNbJ7D bjmFX1UE8yw1TS3Tn5CQQoUBju5nmq6aUEgubd+PhORPMiGJNZiJhKuknOlt/g== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T8dvP2JNJz11GB for ; Tue, 9 Jan 2024 17:58:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 409Hw9u4086598 for ; Tue, 9 Jan 2024 17:58:09 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 409Hw9ol086597 for standards@FreeBSD.org; Tue, 9 Jan 2024 17:58:09 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: standards@FreeBSD.org Subject: [Bug 276220] tty_disc canonical input processing: suprising behavior of the EOF cchar Date: Tue, 09 Jan 2024 17:58:09 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: standards X-Bugzilla-Version: 14.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: kevans@freebsd.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: kevans@freebsd.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status assigned_to cc attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Standards compliance List-Archive: https://lists.freebsd.org/archives/freebsd-standards List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-standards@freebsd.org X-BeenThere: freebsd-standards@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276220 Kyle Evans changed: What |Removed |Added ---------------------------------------------------------------------------- Status|New |In Progress Assignee|standards@FreeBSD.org |kevans@freebsd.org CC| |kevans@freebsd.org --- Comment #2 from Kyle Evans --- Created attachment 247547 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D247547&action= =3Dedit git(1) diff against base I agree with your interpretation of the spec; I think we want something like the attached patch... it searches one past the buffer size for an EOF. If = we find it there, then we will trim it; if we don't, then the next read() will return the remaining portion of the line and optionally trim the EOF (if found). The tty_inq.c portion of the patch just fixes a bogus assertion; if you read later in the function, you'll note that `clen` (thus, `rlen`) is assumed to include `flen`, so we shouldn't bomb out if we're trimming the excess past = the remainder of the buffer. --=20 You are receiving this mail because: You are the assignee for the bug.=