From nobody Sat Apr 15 03:42:11 2023 X-Original-To: standards@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Pyzdw2hv3z45QKJ for ; Sat, 15 Apr 2023 03:42:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Pyzdw0XWtz4F1Z for ; Sat, 15 Apr 2023 03:42:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681530132; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JQxppuLVjlBOmQhz7TdM7HFZfoggTiLNH27+XusXMFs=; b=LYWlZ+N5YrJWQrMi+v3NsUd6rUn9/iZ4O/qGGMkUUA/SDcixmz2eDGdHgTLp7jBNC33MWu QQz6uKUnuVg+shrBU2QhAg1O17xIiTas+wv2emkkWELElS77aBrVfQ4ViT2vSRZKyE4dCf y/jNBZj0FawwjCPL8YzNixhfKfdAKR7hh4OSJ3mZasiJ9gFdavfVxUdikEbSeD4luU8d3q 3feLYyWxz2kJ1Yb8bEjfdn6jCRAwcgxrGKeN1YnwUrQ+TSA2NR0+XuvtqxZhpNHTRDe6Dv p1oswR1QGmyii8EoRa/rvAW/mFn/JU6vlz77euErRRGXxoR9ASv7aT75Ji9sKQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1681530132; a=rsa-sha256; cv=none; b=I1WerKtWndTqzPKNZVLhbY1mtGu3dj/IBCbmB/3YV3zqs9NxfRxVL0LkI/8DXruEJSdMJ7 ryyhvKjdrYgw5C99B3D+vg9VvKBkrPHi7zF5rLrD/nVwvGJM+YEuPV6jAFFrcZrap0TMQy tIJdNHYYX9otYNptDBxu/FuiiNPgcro7EiZQ+alkC/uzRNXTV7aYap/AhFRV7NNRDC9SA/ eeOZ2+pqH4+WNJ6qcCdmeDJBhvctiWV9ZgeMIcOeAka7N1mRgf7HumRSfuPYWCpUOLG1vW mgNNEadMSclhCXvl+THj6by+6XgOvPFGxZ37pBKpisJzw1WibMZKKQVaBkFcqg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Pyzdv623gzrWb for ; Sat, 15 Apr 2023 03:42:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 33F3gBWV012476 for ; Sat, 15 Apr 2023 03:42:11 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 33F3gBIf012475 for standards@FreeBSD.org; Sat, 15 Apr 2023 03:42:11 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: standards@FreeBSD.org Subject: [Bug 270852] Extra characters in config files after upgrade Date: Sat, 15 Apr 2023 03:42:11 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: standards X-Bugzilla-Version: 13.2-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: bektas@yahoo.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: standards@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Standards compliance List-Archive: https://lists.freebsd.org/archives/freebsd-standards List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-standards@freebsd.org X-BeenThere: freebsd-standards@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D270852 Bug ID: 270852 Summary: Extra characters in config files after upgrade Product: Base System Version: 13.2-RELEASE Hardware: amd64 OS: Any Status: New Severity: Affects Many People Priority: --- Component: standards Assignee: standards@FreeBSD.org Reporter: bektas@yahoo.com Hi, This has been a major issuse for sometime. After any release updates, such = as last one I have done recently, after issueing : freebsd-update -r 13.2-RELEASE upgrade (from 13.1) .. At the step The following file could not be merged automatically: /etc/pass= wd Press Enter to edit this file in /usr/bin/vi and resolve the conflicts manually... I get the following post (my default editor is vi) .. <<<<<<< current version # $FreeBSD$ # root:*:0:0:Charlie &:/root:/usr/local/bin/bash =3D=3D=3D=3D=3D=3D=3D root:*:0:0:Charlie &:/root:/bin/csh toor:*:0:0:Bourne-again Superuser:/root: >>>>>>> 13.2-RELEASE .. Major inconsistencies and critical defects: It is an upgrade, should not change passwd file in any way, unless standart= / delimiter / format changed. If user don't pay attention and save it the way= it is then passwd file becomes corrupted. I understand the intent is somewhat adding patch phrase, however, a) it is not the job of upgrade script to change my passwd file. b) It is not the job of upgrade script adding already removed user(s) like 'toor', back. SUPER CRITICAL: Upgrade script patches sshd server system-wide configuration file. It is too crowded already and hard to see/catch patches on screen. If I don't pay enough attention and save it the way it is, it continues with invalid characters inserted into sshd_config. Auto inserted lines similar to the followings are absolute SSHD/PAM killer. @@ -56,10 +55,11 @@ @@ -77,11 +77,11 @@ <<<<<<< current version >>>>>>> ... This once made sshd_config file invalid and, after reboot, SSHD did not sta= rt and I was not able to access server remotely. Almost cost me my job. Please stop this type of standarts in upgrades. Simply dangerous. More harm than good. Instead, create a large files of: 1) what's done/applied, call it UPGRADE-timestamp.upgrade 2) what needs to be confirmed by user, call it PENDING-timestamp.upgrade Let user review and apply further changes. Thanks,. --=20 You are receiving this mail because: You are the assignee for the bug.=