From nobody Sun Sep 10 17:10:26 2023 X-Original-To: freebsd-stable@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RkGZZ0flTz4sXXK for ; Sun, 10 Sep 2023 17:10:46 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic316-54.consmr.mail.gq1.yahoo.com (sonic316-54.consmr.mail.gq1.yahoo.com [98.137.69.30]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4RkGZX5kcqz4G1N for ; Sun, 10 Sep 2023 17:10:44 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yahoo.com header.s=s2048 header.b=itmHyFKj; spf=pass (mx1.freebsd.org: domain of marklmi@yahoo.com designates 98.137.69.30 as permitted sender) smtp.mailfrom=marklmi@yahoo.com; dmarc=pass (policy=reject) header.from=yahoo.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1694365841; bh=LXpQfZDkoQ8F64UEC/En2DjHEoPuw0bPXWd/h+8PRCU=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From:Subject:Reply-To; b=itmHyFKjrKZL5TOUBK+NT31YOq7MWbCjhfOyme5LB+iFIZD4API5rhlypFlmxl9UugnDzR4wA6FDITVnD5OAsirM3kKl1TK5gHgX6kFvXAQfzyLMQ9jr9w3sCcNuR0LRDcfKHIvqYomSwowR1mACRZDOzhKAlT9yH51gO9sz7CSz6Gie84f/vVShx8LoW6Zv35/5Y6vTV7HoYfJDtoHixpFB8CRWgY+Ls4YylKZNNA4wr63Kgs54JdfiPzhIFfhpPln9L21r6FVrJXxnKQcBQ5L2f6M2l7bQYHGTtYGjLafQTctF3zw0i/kpw9oCOI7CNKCWFpDOFQYimvYGl8r5/g== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1694365841; bh=4a/birP/vkOdArxklt5RsWZAT1YQRzY792jkGMMieI8=; h=X-Sonic-MF:Subject:From:Date:To:From:Subject; b=sCzLrG6aG2RFptj+iMKknnJmb5lBtb0163K4wS17ZFiPE9J1zcnM0RyrC5Lop9axZsPmJgHGTakfQXPowIAbH1ZpFYUStjWG1K8G6GblFWeA2pJzPoq6906HbUmzizBJ068Z45zyA3w00Jbbj6mppudielKhH5GHegI1o91SF4g0sP1csd0twE8deWjKuzKR8ur2MJuFO2c3Zp2oSyewt3GPR8o3HECIHlklpXsUxJvmYqF/FaalWk9RyUAj+yUZWeZDdxdIx6DWFntcShfrtcRJ0tRc4tXpaZZMN8blNeB8lGHQekOvF3ZZgeYkTp7jAQFa5Xvma2GVXGfDUnJELg== X-YMail-OSG: h5poq84VM1kOr3clFq5UPfjBmUhymIkrHs83EIKLGv9bp6egRh.2.RhQyjb6iG2 E8FvmfN8NYuadWUW4M65nuDyK9taebSaC1w0Ir_tT82mD7oUHu0i_XKidUubd43yWEV25HSwPYHg FYIzWgINlViEke3oVqvDufTHXF3Dg4eKl4.khjDyI3Bg1mdlOkmbmaZf5.yBdsLxcmUKI2S16H8N jm68GRiPhuTTC5Hhr2_a2Ot_pkG008gYIzMASo4ryjYBTU_rLngT9cy8xjYSX4jczXLG9WUzDXSJ Yl5_0bCZL_5a2DAVoNK3.Sa6JVT5MIMQ1lRDKY8vlE7dLNK0qmzNW9Iiiz653IjGgvQ_N1puVyai qMt4Eb7YLi72wU2wXV06gimI2afFalHnywCRyNmtnCXPLJ5nsY6mRBIuShGB1K3Fm.nCXWBMjsq0 bwe093iXpZIYJWFszgMzwnAnx5Dy9lRWruxq5C2E949cA28zlaZZGOk0_siH6EXkt6dr4wATiRTA I9Y5rejZAZeM5v8UDpNmzBu7kVxceM8q2MYODdcbDwBjsmN9_pxBoUYSVVRSyEL0JjbH1HV5lLsV b8NLSlcerh9KEh0pezlz9tJZ6nwGPQRuYQizpEiesls1Pp4dOV9MlzbV2wjMT40UyRPnvvdn00PW 9eIdDb.jkeJxOn9J9Lub4eI2KpWO.Rz6EMi2TmcM5su7UsnGUvg88aBW6vON8JwtL2c4nGe0RGrq uJw0wUHqj3ecvxUjOz_jgVrfjUuqTCIHe.uOFLQygzPVMi13udWwMcGqG.oNlIQI6Nbgzrz6L5CF fpaCNjl_A3z2UtmxfcPhPGJHdQ6d5d.iVECWacelbzodRJMgkYi21fWSYv6JuiVk4C4Z.hLTnqTK deACAOLepMTMciwX3y58NPuZfxr_keQzkxbelEXSKs8jvCMyv5e8CzfsBa59GH2xHGVfLUzmoxwp afFqlOqAZUY31kA4cW1sycevTiio0OJZwbocKjo8owioXZboGgCIsSpE54ydGTgAnDvKPZzp.7Fm UmlehQoNukdFygKdFQqI6JntMCZRzUlWV8lKhWnVEOkEC_6AJ1MC6nIdFfEs.IYFEf.vw3FMPs0e MBW.dbOwQ5lXNZZQRrPN.TlBv0Aa_8gToSno6wTRYg78Tu_9eJRBrr_PJi4g5uuSgrSpxQgHpur8 Oxrzy5zjiOWdm2401BzNVUKZMHV120LZYZyYrE6j6Ro4z.xXyUUHhEZUmV2QwEfKjxUQKD05kfDZ gAO6GcWtdTqMLH1qLaeQvuaxVFOTWlsHAz9DqHQT9acT.7xzb6RHkPD6VuAm_3KLWbU7vO2d24HU nt2OB4A4CrXSo8Iw7sjJPYtYsG8lgD5qCZBZnmkpPUojLnJ7Qjkmt_0630t3Us3XtpXPDanLjNQ8 GRVLOrpzuyM26bnhvFpcju1tn3bo_yEhGvqkR6HdXUAIxgZgJfR2okbJNHFfeDabn.YSV3att8A0 3_3yRLNJzKCk8ekjoM7c9UkrTlvbluVtrFkS_CS7UZCo558g2wt_csmrN2ZkCeNXmDN_S2a3I2DG AONcXIZeBbl443KZqMqVhkIQ6fX4pi8AmWmr6Z0FxKkINu1WXqh77eI6JbTC_fnRcrFS8LwyM84R K4eJqblRWzyLEttwz1eLFU7ZZJTVRW_Lf2VilyKdzenldjYC38eou9CjPSIwo9HsqhTk67rifGw8 w1vVVerpNOw8cge59LtbYIAYiBYTuioCgJTsMUi9wp8JD9HPs5rGAPAyRe5Y93HDmZuA_tFgheUh DgpWUbRxFe9979UhH8EvRsq_k54aS3sy0VzyxZ7TxSUC0JtbQevmUazFaEkVU.qYkLAeT0yO4S3U SZgdEiy2dmb.7FMEv83iQfJUlP02DdfY4cG6NLz6WK3dPf7RMOy7zNYZrREtxgkjDby_jilw.QtA zHSEWmSS.5uKqhk943GZhRzxJ7tva_UG59vRrvoUS9avKidnuluT2Ockrgh2YePO783ICvY809tX hDTw3rgOHsi51zsua3gAzmugmDH0qLzAxAoadiFP7wtFCT7okFajXMqPivste4Z2isr0wDcdcsbF a5VwWLw7wi6CocahvwbkLgSZbtrJrFGF5g2SiTJ7PA1xFGxqGeO2PmzYVT.VumIlCtFGNSv5AvMu zuZ1PV2wz8uOvdK1SKWaMlnhN2vgr6dHpdceHjdZ6pN_hmWvqlY7uEy1BHmxjqgL_yBAAJSNh9O0 O0USq.rAUHnCNYeErNdBSaJJV8N5WOulei0OWKb0KAXj2zfalL9Lggn2fBe1sJZUI6WuMU9WmJXI MVtJ_4G3q6dIXx82HXA-- X-Sonic-MF: X-Sonic-ID: e0b07d16-561a-4fb4-a097-dc3f0c467ae3 Received: from sonic.gate.mail.ne1.yahoo.com by sonic316.consmr.mail.gq1.yahoo.com with HTTP; Sun, 10 Sep 2023 17:10:41 +0000 Received: by hermes--production-gq1-6b7c87dcf5-sv5pn (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID bbc79512b09273d6f9bac26b4e1e9c04; Sun, 10 Sep 2023 17:10:37 +0000 (UTC) Content-Type: text/plain; charset=us-ascii List-Id: Production branch of FreeBSD source code List-Archive: https://lists.freebsd.org/archives/freebsd-stable List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Subject: Re: Looks like the kyua zfs tests likely are not used on aarch64 or other contexts with unsigned char From: Mark Millard In-Reply-To: <96C2F8F3-D3F0-48FC-BEEC-E3C983BD680A@yahoo.com> Date: Sun, 10 Sep 2023 10:10:26 -0700 Cc: Current FreeBSD , FreeBSD-STABLE Mailing List , freebsd-arm Content-Transfer-Encoding: 7bit Message-Id: References: <96C2F8F3-D3F0-48FC-BEEC-E3C983BD680A@yahoo.com> To: Martin Matuska , Alexander Motin , Pawel Jakub Dawidek , Glen Barber , Mike Karels X-Mailer: Apple Mail (2.3731.700.6) X-Spamd-Bar: --- X-Spamd-Result: default: False [-3.50 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; MV_CASE(0.50)[]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; MIME_GOOD(-0.10)[text/plain]; FROM_HAS_DN(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; BLOCKLISTDE_FAIL(0.00)[98.137.69.30:server fail]; ARC_NA(0.00)[]; MLMMJ_DEST(0.00)[freebsd-stable@freebsd.org]; RCVD_IN_DNSWL_NONE(0.00)[98.137.69.30:from]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; RWL_MAILSPIKE_POSSIBLE(0.00)[98.137.69.30:from]; DKIM_TRACE(0.00)[yahoo.com:+]; TO_DN_ALL(0.00)[]; FREEMAIL_FROM(0.00)[yahoo.com]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_SEVEN(0.00)[8]; RCVD_TLS_LAST(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Queue-Id: 4RkGZX5kcqz4G1N On Sep 10, 2023, at 00:31, Mark Millard wrote: > kyua tests that use the: > > /usr/tests/sys/cddl/zfs/bin/mkfile > > program like so (for example): > > mkfile 500M /testpool.1861/bigfile.0 > > (which should be valid) end up with mkfile > instead reporting: > > Standard error: > Usage: mkfile [-nv] [e|p|t|g|m|k|b] ... > > which prevent the kyua test involved from working. > > Turns out this is from expecting char to be always > signed (so a -1 vs. 255 distinction, here in an > aarch64 context): > > . . . > (gdb) list > 179 /* Options. */ > 180 while ((ch = getopt(argc, argv, "nv")) != -1) { > 181 switch (ch) { > 182 case 'n': > 183 nofill = 1; > 184 break; > 185 case 'v': > (gdb) print ch > $16 = 255 '\377' > (gdb) print/x -1 > $17 = 0xffffffff > (gdb) print/x ch > $18 = 0xff > . . . > > With the mix of unsigned and signed it ends up > being a 0xffu != 0xffffffffu test, which is > always true. > > So the switch is reached as if a "-" prefix was > present (that is not). Then the "option" is classified > as invalid and the usage message is produced. > > Apparently no one had noticed. That, in turn, suggests a > lack of inspected testing on aarch64, powerpc64, > powerpc64le, armv7, powerpc, and powerpcspe. That, in > turn, suggests that kyua test inspection for the likes > of aarch64 is not historically a part of the release > process for openzfs or for operating systems that include > openzfs. > Looks like the mkfile.c traces back to a former port sysutils/mkfile that was unfetchable as of 2019. And, looking around, it seems the kyua zfs tests may be a FreeBSD only thing, not adopted in openzfs. So various implicit assumptions when I wrote the note do not actually hold. FreeBSD would have to do additional testing via kyua, beyond what openzfs does for testing, to discover the unsigned char related mis-behavior in the mkfile that FreeBSD's kyua tests use. Only FreeBSD variants are likely to have a similar status, not general openzfs including operating systems. === Mark Millard marklmi at yahoo.com