From nobody Wed Feb 22 12:30:45 2023 X-Original-To: freebsd-stable@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PMFr34Zqsz3sxQJ for ; Wed, 22 Feb 2023 12:30:59 +0000 (UTC) (envelope-from mpp302@gmail.com) Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PMFr32qFpz3Kvc; Wed, 22 Feb 2023 12:30:59 +0000 (UTC) (envelope-from mpp302@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-f54.google.com with SMTP id cq23so29411659edb.1; Wed, 22 Feb 2023 04:30:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Yjic18JKoEuyJbE3K7FF//WVAEl4kiLos2ToMAeymco=; b=42qusJ/hRjn/a6xPYyowNO2ii9dqT+eXldySVowDU7knGKB6GqliNmoJLxyYqvIvHf tMES0yhzPuFp3uzSWiWyHsnd7L8L9xg2J/xsHodH/LSXXy+Nq5XR+5NoUZ9RN1pSZgq1 VwlpPyHrhtCXC3Zu/faAKYDoepQ/x4FGWqyiq0j3eM/VoXKsbSwm1PNiSZnkT3HU/PJw 8Hqc3HmKunNDEHSJFOC6WFpITNczqjwRzQys9Lft6qEATkSaAMJV7J0dUFdxiAf6w0p6 e6BtJFUl49+KtPFEciTw8U/l9dfdzTQRBmk1W5Md2rWvnwdhFkFtcr6f9Ystax9BheRq jKIA== X-Gm-Message-State: AO0yUKUibHleiQAVgFcD3fXj+H6VuBnABrEQTAy9jjkvvbHdsdSpBr24 VbLbuejqn7W3Rz2Aa7cGVuSUxgGcHQrE1g== X-Google-Smtp-Source: AK7set98iS9EY9H74qSqIRtS3SEEUMI4f/srpPPtcINKPbjwa27x4oECLhDh9MhsdHMq2eV9g19STQ== X-Received: by 2002:a05:6402:268e:b0:4ac:d21b:2a44 with SMTP id w14-20020a056402268e00b004acd21b2a44mr7859626edd.0.1677069057961; Wed, 22 Feb 2023 04:30:57 -0800 (PST) Received: from smtpclient.apple ([2a02:8109:86c0:6814:9d98:f756:cd06:4265]) by smtp.gmail.com with ESMTPSA id j24-20020a1709062a1800b0087223b8d6efsm8511882eje.16.2023.02.22.04.30.57 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Feb 2023 04:30:57 -0800 (PST) From: Mateusz Piotrowski <0mp@FreeBSD.org> Message-Id: <96BBD91C-65D9-441F-8151-3D5AFF15910F@FreeBSD.org> Content-Type: multipart/alternative; boundary="Apple-Mail=_6EE9456B-28DF-4D31-8A15-A526A8304C56" List-Id: Production branch of FreeBSD source code List-Archive: https://lists.freebsd.org/archives/freebsd-stable List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.400.51.1.1\)) Subject: Re: stable/13 snapshot's /etc/rc.d/machine_id has use of main's startmsg from /etc/rc.subr so it reports 2 "eval: startmsg: not found" Date: Wed, 22 Feb 2023 13:30:45 +0100 In-Reply-To: Cc: Mark Millard , FreeBSD-STABLE Mailing List , jlduran@gmail.com, Warner Losh , "Tobias C. Berner" To: Zhenlei Huang References: <212E6139-C634-4AE3-BFCF-F241D0C841CD.ref@yahoo.com> <212E6139-C634-4AE3-BFCF-F241D0C841CD@yahoo.com> <5EA6BBBB-5947-4F78-9EB1-D9506FCA1860@FreeBSD.org> X-Mailer: Apple Mail (2.3731.400.51.1.1) X-Rspamd-Queue-Id: 4PMFr32qFpz3Kvc X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --Apple-Mail=_6EE9456B-28DF-4D31-8A15-A526A8304C56 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hey, thanks for the report! > On 22. Feb 2023, at 02:31, Zhenlei Huang wrote: >=20 > Sorry for missing the author tcberner@ of = `libexec/rc/rc.d/machine_id`. >=20 >> On Feb 22, 2023, at 9:25 AM, Zhenlei Huang > wrote: >>=20 >> Hi, >>=20 >> `libexec/rc/rc.d/machine_id` (https://reviews.freebsd.org/D37722) is = MFC'ed into stable/13 but its precedence = https://reviews.freebsd.org/D34514 is not. >>=20 >> So we should either MFC D34514, or change libexec/rc/rc.d/machine_id = in stable/13 to use `check_startmsgs`. I MFC=E2=80=99d two patches related to startmsg to stable/13. Best, Mateusz --Apple-Mail=_6EE9456B-28DF-4D31-8A15-A526A8304C56 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8
Hey, = thanks for the report!

On 22. Feb 2023, at 02:31, Zhenlei Huang = <zlei@FreeBSD.org> wrote:

Sorry for missing the author tcberner@ of = `libexec/rc/rc.d/machine_id`.

On Feb 22, 2023, at 9:25 AM, Zhenlei Huang <zlei@FreeBSD.org> = wrote:

Hi,

`libexec/rc/rc.d/machine_id` = (https://reviews.freebsd.org/D3= 7722) is MFC'ed into stable/13 but its precedence https://reviews.freebsd.org/D3= 4514 is not.

So we should either MFC = D34514, or change libexec/rc/rc.d/machine_id in stable/13 to use `check_startmsgs`.

I MFC=E2=80=99d two patches related to startmsg to = stable/13.

Best,
Mateusz

= --Apple-Mail=_6EE9456B-28DF-4D31-8A15-A526A8304C56--