From nobody Wed Feb 22 01:31:04 2023 X-Original-To: freebsd-stable@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PLzBp0GWCz3tmKP for ; Wed, 22 Feb 2023 01:31:14 +0000 (UTC) (envelope-from zlei@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PLzBn63Jxz3Kv1; Wed, 22 Feb 2023 01:31:13 +0000 (UTC) (envelope-from zlei@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1677029473; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q/1yUWFBUDEfZVPHT6/cVOqZVYiJ6U/T+P2jC8HFRmM=; b=kGT51tdPoFmAlx6axKgFkcfUQBk8yfpr5YmuOlWKEq3+oxo91oVNe62HzLk0D/lciL3IbW ZbX9fXmkesQnY0syst8oxZsFEaYKGlavfRVzeAe+wKUjScK0to6FTxG88DJ1VR9ESnSx1J K7dwQ3HW6CdOuW8ALvzQBiv9V/mWWubjNFd2XvKyEeve6VnyUy3xLfGvVS/AzyxgLiOoRd m2bwhfkqqMq7269De40jI4TYiuLwlWpTidTSVgmzVQl1TIbIWeWjeV74UBZcS4kdDimZow H8++v4gK1x7f+NNC/nyYe31NqHnMBzjEm/uDfw7bmixha//h+PPaTyiDq7ahbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1677029473; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q/1yUWFBUDEfZVPHT6/cVOqZVYiJ6U/T+P2jC8HFRmM=; b=JGVPLmMqAgydD5jXH7xBkTX/owp/dv58rLgH/HV9WGw9GNaFKh/YuMuOAzBm3Un3tOrNgS +1WpSkzf2YM8oMI3rC21SxATgFcD4z/EoCUL2oe8xVP/aIjDcXcWXqixi13j/j59P2HkfO ILy+zEeVHsewle8qJcrBrOpzCjDKiHVX/7V98it04c+e+h0VesT0QAShJ9xJFnDtP+i1j0 7usE8DJ7BfblQ1lbpVk2FjbrfKUo0gIJN8ImUZdneKWkvGEa1P/7PjIfNLIwwkeYerQqAP oRPjQ9nlIaOBQBRX6cwlualTFTEtCR19YfFiBB/KbzETeWzTh5aAlffrqjH/uQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1677029473; a=rsa-sha256; cv=none; b=FKzk8416VDzrV+EforU3YTgUQfsLKIh6jXJq5J89eTSHjBNCWn6ZF7WIe2Oz8punENwoc7 /6LqhbI5gd599EHAmNgA/CW000mrUQP2xQ0wwCXecWdpSMy/aqAN3HBEVOmgygmIPcZEtI 884wjGiSEVygTXT+Jk9uzegHVk+ZWFv2Qb1SvDTMcoojMtFguAuKfwrQnlmvg14Q8Ko33r /QY3AnpGHM6zuyEgxBl8qUH5kQ0glWh07eijdXDxie3IOVd6RP/rp/ZArqcp+7WjbzxuFm 7/uMLImjZjC2oc0wJD6xiM9TyeBG/mKGleCPjnGmnnZAxIstQ2TU7GKXXwo+ZA== Received: from smtpclient.apple (ns1.oxydns.net [45.32.91.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: zlei/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PLzBl3svrzlwG; Wed, 22 Feb 2023 01:31:11 +0000 (UTC) (envelope-from zlei@FreeBSD.org) From: Zhenlei Huang Message-Id: Content-Type: multipart/alternative; boundary="Apple-Mail=_BEE7CF78-A86C-407C-8464-4932DBF1AE8E" List-Id: Production branch of FreeBSD source code List-Archive: https://lists.freebsd.org/archives/freebsd-stable List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.2\)) Subject: Re: stable/13 snapshot's /etc/rc.d/machine_id has use of main's startmsg from /etc/rc.subr so it reports 2 "eval: startmsg: not found" Date: Wed, 22 Feb 2023 09:31:04 +0800 In-Reply-To: <5EA6BBBB-5947-4F78-9EB1-D9506FCA1860@FreeBSD.org> Cc: FreeBSD-STABLE Mailing List , jlduran@gmail.com, Warner Losh , Mateusz Piotrowski <0mp@FreeBSD.org>, "Tobias C. Berner" To: Mark Millard References: <212E6139-C634-4AE3-BFCF-F241D0C841CD.ref@yahoo.com> <212E6139-C634-4AE3-BFCF-F241D0C841CD@yahoo.com> <5EA6BBBB-5947-4F78-9EB1-D9506FCA1860@FreeBSD.org> X-Mailer: Apple Mail (2.3696.120.41.1.2) X-ThisMailContainsUnwantedMimeParts: N --Apple-Mail=_BEE7CF78-A86C-407C-8464-4932DBF1AE8E Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Sorry for missing the author tcberner@ of `libexec/rc/rc.d/machine_id`. > On Feb 22, 2023, at 9:25 AM, Zhenlei Huang wrote: >=20 > Hi, >=20 > `libexec/rc/rc.d/machine_id` (https://reviews.freebsd.org/D37722 = ) is MFC'ed into stable/13 but its = precedence https://reviews.freebsd.org/D34514 = is not. >=20 > So we should either MFC D34514, or change libexec/rc/rc.d/machine_id = in stable/13 to use `check_startmsgs`. >=20 > I'd personally prefer MFCing ;) >=20 > Best regards, > Zhenlei >=20 >> On Jan 22, 2023, at 11:32 AM, Mark Millard > wrote: >>=20 >> When I booted a new stable/13 snapshot install, the messaging >> included: >>=20 >> . . . >> Updating motd:. >> eval: startmsg: not found >> eval: startmsg: not found >> Clearing /tmp (X related). >> . . . >>=20 >> It looks like the "eval: startmsg: not found" lines >> are from: >>=20 >> # grep -r "\" /etc/=20 >> /etc/rc.d/machine_id: startmsg -n "Creating = ${machine_id_file} " >> /etc/rc.d/machine_id: startmsg 'done.' >>=20 >> (No more matches found.) >>=20 >> The following was not found on stable/13: >>=20 >> /etc/rc.subr:# startmsg >> /etc/rc.subr:startmsg() >> /etc/rc.subr: startmsg "Starting ${name}." >>=20 >>=20 >> =3D=3D=3D >> Mark Millard >> marklmi at yahoo.com >>=20 >>=20 >=20 >=20 >=20 --Apple-Mail=_BEE7CF78-A86C-407C-8464-4932DBF1AE8E Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii Sorry= for missing the author tcberner@ of `libexec/rc/rc.d/machine_id`.

On Feb 22, 2023, at 9:25 AM, Zhenlei Huang <zlei@FreeBSD.org> = wrote:

Hi,

`libexec/rc/rc.d/machine_id` (https://reviews.freebsd.org/D37722) is MFC'ed into = stable/13 but its precedence https://reviews.freebsd.org/D34514 is not.

So we should either MFC = D34514, or change libexec/rc/rc.d/machine_id in stable/13 to use `check_startmsgs`.

I'd personally = prefer MFCing ;)

Best regards,
Zhenlei

On Jan 22, 2023, at 11:32 AM, Mark Millard <marklmi@yahoo.com> = wrote:

When I booted a new stable/13 snapshot install, the = messaging
included:

. . .
Updating motd:.
eval: startmsg: not found
eval: startmsg: not found
Clearing /tmp (X = related).
. . .

It looks like = the "eval: startmsg: not found" lines
are from:

# grep -r "\<startmsg\>" /etc/
/etc/rc.d/machine_id: =           startmsg -n = "Creating ${machine_id_file} "
/etc/rc.d/machine_id: =           startmsg = 'done.'

(No more matches found.)

The following was not found on stable/13:

/etc/rc.subr:# startmsg
/etc/rc.subr:startmsg()
/etc/rc.subr: =             &n= bsp;     startmsg "Starting ${name}."


=3D=3D=3D
Mark = Millard
marklmi at yahoo.com






= --Apple-Mail=_BEE7CF78-A86C-407C-8464-4932DBF1AE8E--