From nobody Wed Feb 22 01:25:42 2023 X-Original-To: freebsd-stable@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PLz4c2b7Dz3tlLy for ; Wed, 22 Feb 2023 01:25:52 +0000 (UTC) (envelope-from zlei@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PLz4c1RJhz3JVT; Wed, 22 Feb 2023 01:25:52 +0000 (UTC) (envelope-from zlei@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1677029152; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aAwwYV3oT09BeDyQSDwvmnr2aZBl0xctc6Dz4RBlMXE=; b=R/6UmQG3ShWzDz1RIrGEmhbzmSO7xBPmc4CVEvncH+kwj+JM0dPf7096FO75WYc8h/62lL /851mK3ud7xQbLlvKA0nzukl9CwAxXbTeSDeCt7d54yT9/l92kB5Yepihc1BESgc/XE00d wQpMxAbAuE99MlDkw7/CGbwYu0QZzDThmkQNdPbIYE35GkjNPPmVRKZF7gC5zyFaMX8qEz m5lH0wIcsADckMVB70j7U2RbQaRHTuFHuQuQDVtwfl/6BtNyGtduGwh2jOiN5dn8hS33hq W08lb81fDMSqL9wHVhydA3Cyt2hWN3vu2s2F7Nsl645u2tTbZeLHmlVPPqC1jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1677029152; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aAwwYV3oT09BeDyQSDwvmnr2aZBl0xctc6Dz4RBlMXE=; b=Lap6dgnThYQvmQqpimPpYPyrPG+W4Odob2UmBVkQymvqvnWbbsDku6WceIIqdFBVqLJ2v7 d6ioUXZiTL18YCN1bQpq/qd1VCSPHy7W09bE3mQZHQBepSpZnFWEbhmbOEPv1z79Y1CpnJ kg9brbJie3LUOPL/nHcNjWE4sqr3TXD0n1SBz23R3XmNKdLeFq6UsE8ceWOvPtU7DN6q8L X33gxmPc3r+Dnvn8py5hNyula7/Pk/dnO2cJZsN+VS8qGuXZ5qhzYn8n7e3Uj/xWN5jGq0 x07LdPczxSGCXTM/Ys2Um3WPnnmCCFilmgTrJ7dLnt7uHaT6EXp+hUHbyGHpZg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1677029152; a=rsa-sha256; cv=none; b=au5FOMRJAXh+vxvquaE2dy75jCD9jbI8F5GzMznyeqK8oDeE0yPwQqhVOABooyzzSJovmN D9bRw6hkkFknaKk2CE1t82ZeUL3xS7o4yig0d4VtzNc61WFN+oQu8c3f/GVP+LndfjDcGj Y8P3vT3uXxjkWfjgrbXyj8eyzZpcGcfHuwgdeavBVU0z7Dk1U7YBdPHVQ+Fa9qlvuNHHZd Bn8VW2eVEdi/C1nZfc1MO1BF17wBPQFsh4Y0oDmEYk8xRvsk+swtB4zZfeQ1SWgsmKoYPv NXKrUZOwSm7iC1TKtcmoIKX40cR6fwErxN0NtryAD3vREmh9pCizwj+5aHgLUA== Received: from smtpclient.apple (ns1.oxydns.net [45.32.91.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: zlei/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PLz4Z0KvwzlnY; Wed, 22 Feb 2023 01:25:49 +0000 (UTC) (envelope-from zlei@FreeBSD.org) From: Zhenlei Huang Message-Id: <5EA6BBBB-5947-4F78-9EB1-D9506FCA1860@FreeBSD.org> Content-Type: multipart/alternative; boundary="Apple-Mail=_1BD9FAC0-44C6-49E4-9ED9-FDAFBDC0AC37" List-Id: Production branch of FreeBSD source code List-Archive: https://lists.freebsd.org/archives/freebsd-stable List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.2\)) Subject: Re: stable/13 snapshot's /etc/rc.d/machine_id has use of main's startmsg from /etc/rc.subr so it reports 2 "eval: startmsg: not found" Date: Wed, 22 Feb 2023 09:25:42 +0800 In-Reply-To: <212E6139-C634-4AE3-BFCF-F241D0C841CD@yahoo.com> Cc: FreeBSD-STABLE Mailing List , jlduran@gmail.com, Warner Losh , Mateusz Piotrowski <0mp@FreeBSD.org> To: Mark Millard References: <212E6139-C634-4AE3-BFCF-F241D0C841CD.ref@yahoo.com> <212E6139-C634-4AE3-BFCF-F241D0C841CD@yahoo.com> X-Mailer: Apple Mail (2.3696.120.41.1.2) X-ThisMailContainsUnwantedMimeParts: N --Apple-Mail=_1BD9FAC0-44C6-49E4-9ED9-FDAFBDC0AC37 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Hi, `libexec/rc/rc.d/machine_id` (https://reviews.freebsd.org/D37722 = ) is MFC'ed into stable/13 but its = precedence https://reviews.freebsd.org/D34514 = is not. So we should either MFC D34514, or change libexec/rc/rc.d/machine_id in = stable/13 to use `check_startmsgs`. I'd personally prefer MFCing ;) Best regards, Zhenlei > On Jan 22, 2023, at 11:32 AM, Mark Millard wrote: >=20 > When I booted a new stable/13 snapshot install, the messaging > included: >=20 > . . . > Updating motd:. > eval: startmsg: not found > eval: startmsg: not found > Clearing /tmp (X related). > . . . >=20 > It looks like the "eval: startmsg: not found" lines > are from: >=20 > # grep -r "\" /etc/=20 > /etc/rc.d/machine_id: startmsg -n "Creating = ${machine_id_file} " > /etc/rc.d/machine_id: startmsg 'done.' >=20 > (No more matches found.) >=20 > The following was not found on stable/13: >=20 > /etc/rc.subr:# startmsg > /etc/rc.subr:startmsg() > /etc/rc.subr: startmsg "Starting ${name}." >=20 >=20 > =3D=3D=3D > Mark Millard > marklmi at yahoo.com >=20 >=20 --Apple-Mail=_1BD9FAC0-44C6-49E4-9ED9-FDAFBDC0AC37 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii Hi,

`libexec/rc/rc.d/machine_id` (https://reviews.freebsd.org/D37722) is MFC'ed into = stable/13 but its precedence https://reviews.freebsd.org/D34514 is not.

So we should either MFC = D34514, or change libexec/rc/rc.d/machine_id in stable/13 to use = `check_startmsgs`.

I'd personally prefer MFCing ;)

Best regards,
Zhenlei

On Jan 22, 2023, at 11:32 AM, = Mark Millard <marklmi@yahoo.com> wrote:

When = I booted a new stable/13 snapshot install, the messaging
included:

. . .
Updating motd:.
eval: startmsg: not found
eval: startmsg: not found
Clearing /tmp (X = related).
. . .

It looks like = the "eval: startmsg: not found" lines
are from:

# grep -r "\<startmsg\>" /etc/
/etc/rc.d/machine_id: =           startmsg -n = "Creating ${machine_id_file} "
/etc/rc.d/machine_id: =           startmsg = 'done.'

(No more matches found.)

The following was not found on stable/13:

/etc/rc.subr:# startmsg
/etc/rc.subr:startmsg()
/etc/rc.subr: =             &n= bsp;     startmsg "Starting ${name}."


=3D=3D=3D
Mark = Millard
marklmi at yahoo.com




= --Apple-Mail=_1BD9FAC0-44C6-49E4-9ED9-FDAFBDC0AC37--