Re: Build breakage on stable/13

On Wed, Feb 15, 2023 at 08:47:05AM +0100, Eivind Nicolay Evensen wrote:
> I noticed after updating stable/13 around yesterday the below build breakage.
> At first glance it looks to me like this doesn't like nooptions INET6.
> 
> Regards, Eivind
> 
> --- isci.o ---
> cc -target x86_64-unknown-freebsd13.2 --sysroot=/usr/obj/usr/src/amd64.amd64/tmp -B/usr/obj/usr/src/amd64.amd64/tmp/usr/bin  -O2 -pipe -fno-common  -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -DKLD_TIED -nostdinc   -DHAVE_KERNEL_OPTION_HEADERS -include /usr/obj/usr/src/amd64.amd64/sys/ENE-spurv/opt_global.h -I. -I/usr/src/sys -I/usr/src/sys/contrib/ck/include -fno-common -g -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fdebug-prefix-map=./machine=/usr/src/sys/amd64/include -fdebug-prefix-map=./x86=/usr/src/sys/x86/include -I/usr/obj/usr/src/amd64.amd64/sys/ENE-spurv     -MD  -MF.depend.isci.o -MTisci.o -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float  -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragma
>  s -Wno-error=tautological-compare -Wno-error=empty-body -Wno-error=parentheses-equality -Wno-error=unused-function -Wno-error=pointer-sign -Wno-error=shift-negative-value -Wno-address-of-packed-member -Wno-error=unused-but-set-variable -Wno-format-zero-length   -mno-aes -mno-avx  -std=iso9899:1999 -c /usr/src/sys/dev/isci/isci.c -o isci.o
> /usr/src/sys/dev/isci/isci.c:194:14: warning: variable 'status' set but not used [-Wunused-but-set-variable]
>                 SCI_STATUS status;
>                            ^
> --- all_subdir_irdma ---
> --- irdma_cm.o ---
> /usr/src/sys/modules/irdma/../../dev/irdma/irdma_cm.c:1643:11: error: implicit declaration of function 'ip6_ifp_find' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
>         ip_dev = ip6_ifp_find(&init_net, laddr6, scope_id);
>                  ^
> /usr/src/sys/modules/irdma/../../dev/irdma/irdma_cm.c:1643:11: note: did you mean 'ip_ifp_find'?
> /usr/src/sys/modules/irdma/../../ofed/include/rdma/ib_addr_freebsd.h:36:1: note: 'ip_ifp_find' declared here
> ip_ifp_find(struct vnet *vnet, uint32_t addr)
> ^
> --- all_subdir_isci ---
> /usr/src/sys/dev/isci/isci.c:290:11: warning: variable 'scic_log_object_mask' set but not used [-Wunused-but-set-variable]
> --- all_subdir_irdma ---
> /usr/src/sys/modules/irdma/../../dev/irdma/irdma_cm.c:1643:9: error: incompatible integer to pointer conversion assigning to 'struct ifnet *' from 'int' [-Werror,-Wint-conversion]
>         ip_dev = ip6_ifp_find(&init_net, laddr6, scope_id);
>                ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> --- all_subdir_isci ---
>         uint32_t scic_log_object_mask;
>                  ^
> /usr/src/sys/dev/isci/isci.c:289:11: warning: variable 'verbosity_mask' set but not used [-Wunused-but-set-variable]
>         uint32_t verbosity_mask;
>                  ^
> /usr/src/sys/dev/isci/isci.c:291:11: warning: variable 'scif_log_object_mask' set but not used [-Wunused-but-set-variable]
>         uint32_t scif_log_object_mask;
>                  ^
> --- all_subdir_irdma ---
> --- irdma_hw.o ---
> ctfconvert -L VERSION -g irdma_hw.o
> 
> make[1]: stopped in /usr/src
> 
> make: stopped in /usr/src

The following commit was not merged from main: 

commit acdfbc6cbe0a8a976d446216be84994c8ee8d5c1
Author: Mitchell Horne
Date:   Mon May 30 17:47:32 2022 -0300

   irdma: fix LINT-NOIP/NOINET/NOINET6 builds


git-cherry-pick seems to resolve the issue.

--
Herbert