Re: [PATCH] Re: 12.2 Splay Tree ipfw potential panic source

Reply: Lutz Donnerhacke : "Re: 12.2 Splay Tree ipfw potential panic source"
In reply to: Stefan Esser : "[PATCH] Re: 12.2 Splay Tree ipfw potential panic source"
Go to: [ bottom of page ] [ top of archives ] [ this month ]

From: Lutz Donnerhacke <lutz_at_donnerhacke.de>
Date: Sat, 10 Jul 2021 12:33:51 UTC

On Sat, Jul 10, 2021 at 10:52:48AM +0200, Stefan Esser wrote:
> > /sys/netinet/libalias/alias_db.c:1753:
> > 
> >         if (packets % packet_limit == 0) {
> > 
> > Seems that packet_limit can become zero, there ...
> > 
> > At line 1780 within that function:
> > 
> >       		if (now != LibAliasTime) {
> >                         /* retry three times a second */
> >                         packet_limit = packets / 3;
> >                         packets = 0;
> >                         LibAliasTime = now;
> >                 }

Thank you for deducing the reason.
Seem to be my fault.
I only tested it with heavy traffic.

The +1 solution seems to be the best one, because the real number is not
important (+100 works, too) and this way the per packet code path is kept to
a minimum of instructions.

Does a bug ticket exists?
I'll issue a review tomorrow.