[Bug 264848] mpr0: mpr_user_pass_thru: user reply buffer (64) smaller than returned buffer (68)

From: <bugzilla-noreply_at_freebsd.org>
Date: Tue, 05 Jul 2022 16:37:52 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=264848

--- Comment #6 from Mark Johnston <markj@FreeBSD.org> ---
Created attachment 235088
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=235088&action=edit
proposed patch

Patch for an issue pointed out by Scott:

The problems is here in mps_get_iocfacts()                                      

        snprintf(sysctlname, sizeof(sysctlname), "dev.%s.%d.msg_version",       
            is_mps ? "mps" : "mpr", mps_unit);                                  

        factslen = sizeof(MPI2_IOC_FACTS_REPLY);                                
        len = sizeof(msgver);                                                   
        error = sysctlbyname(sysctlname, msgver, &len, NULL, 0);                
        if (error == 0) {                                                       
                if (strncmp(msgver, "2.6", sizeof(msgver)) == 0)                
                        factslen += 4;                                          
        }                                                                       

I haven’t been keeping track, but I’ll guess that msgver has numerically
advanced past “2.6” for this system.

-- 
You are receiving this mail because:
You are the assignee for the bug.