From nobody Thu Jun 24 17:37:46 2021 X-Original-To: freebsd-scsi@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4E56D11DB9FA for ; Thu, 24 Jun 2021 17:38:00 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4G9nQv3qSFz4tvl for ; Thu, 24 Jun 2021 17:37:59 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: by mail-pj1-x102f.google.com with SMTP id k5so3924504pjj.1 for ; Thu, 24 Jun 2021 10:37:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=o93lm0SEBc0+O7r2i4QlgWkRcI1DOCkhBlHgEa1wMD8=; b=k6JgYI9YrzQL4qJj1rzkPYW4afoXrXHtRPxH0Ed9uuVIkrf6s8zZ+ak5fJ47x1tAey YuhQrGLcOpJg5C1d2hDdi/mv0qhxhNvgkoC/5mQElV/gA1cRgX7db4NRY5tG+fGS0ts2 v8YaX/IFsUZ1V8Fmw6Ob7Iv7xPYK2rqzURjODcoEq3kSuVPIobHlR3sdco1KLAiPgdRm pyCU+iw+FZgR3io/Oz0H0WdjFhOA98wd3PzIqzZkpWvlR8jXGFpcTvZdWis5PCO5d0vV EyBhkizlB6hoGNOSCuQCRBdLc5k1ZT4JgFlRFoiwbz1zduQyr2wBtKv+d4mx3pI1n+TQ DnWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=o93lm0SEBc0+O7r2i4QlgWkRcI1DOCkhBlHgEa1wMD8=; b=coliyK67jcnB6Q8Ga93Kb9bOUhrrRXYKB1mqFzbAowQZ78g3i6+KoVFjANHC53slRh kLPyYcqhCFPEpqjCsdbbrGEuYI9X4CFe8zJretG5osSh2ihVzObLy/ACaKnReQFVE9q+ 2LSa5xj9ZvTASSjhA+TECMZ9blsx8Df400Yd1yNT3RvuBxVY5UgNkahlubXNOQsszZdR ws07lo5o4/FWl0KRScROcmpxHN4rrLknhiRXfKQRyuQAqbefk0uu/8Q51w/pWhT7p7zQ 6yas79nv2cMmi+jgTaBSy0ZPwvbtYmG7nyeXMpy+v7snRAqaNz+QU0v1h7clyg3X2QxF cIPQ== X-Gm-Message-State: AOAM532c0OQXBluMv2n5rOgIqfVUhh/CvpMK+He6mNr0pNuMAxdyIo3/ Fkp6vgh1RgsWc+AH667wrhOAuDC0w0ryz2TeWvLN6iLuedA= X-Google-Smtp-Source: ABdhPJxMJvGw+A3Th/cZ9StfjndhPN9vojITWoxUNwMd8hspS0A32se99Hg3BpPahgd20ofi282qzz0rlugOoKFqz9s= X-Received: by 2002:a17:903:304e:b029:11d:41c:fa73 with SMTP id u14-20020a170903304eb029011d041cfa73mr5214759pla.82.1624556277179; Thu, 24 Jun 2021 10:37:57 -0700 (PDT) List-Id: SCSI subsystem List-Archive: https://lists.freebsd.org/archives/freebsd-scsi List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-scsi@freebsd.org X-BeenThere: freebsd-scsi@freebsd.org MIME-Version: 1.0 References: In-Reply-To: From: Ryan Stone Date: Thu, 24 Jun 2021 13:37:46 -0400 Message-ID: Subject: Re: Converting ctl.conf to UCL To: freebsd-scsi@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4G9nQv3qSFz4tvl X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=k6JgYI9Y; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of rysto32@gmail.com designates 2607:f8b0:4864:20::102f as permitted sender) smtp.mailfrom=rysto32@gmail.com X-Spamd-Result: default: False [-4.00 / 15.00]; FREEMAIL_FROM(0.00)[gmail.com]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; TO_DN_NONE(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RBL_DBL_DONT_QUERY_IPS(0.00)[2607:f8b0:4864:20::102f:from]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-scsi@freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; SPAMHAUS_ZRD(0.00)[2607:f8b0:4864:20::102f:from:127.0.2.255]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::102f:from]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[freebsd-scsi] X-ThisMailContainsUnwantedMimeParts: N I found the problem. My configuration falls into this special case for the target port config: https://cgit.freebsd.org/src/tree/usr.sbin/ctld/uclparse.c#n841 The early return in that block means that the lun property is never parsed. Moving the port property to the end fixes the issue, but this looks like a bug to me. I think that a continue is probably more appropriate here than a return 0.