From nobody Thu Oct 14 12:53:42 2021 X-Original-To: ruby@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id DA8761804702 for ; Thu, 14 Oct 2021 12:53:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HVTqB5TwSz3Ddr for ; Thu, 14 Oct 2021 12:53:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 91E0513A2E for ; Thu, 14 Oct 2021 12:53:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 19ECrgJv045049 for ; Thu, 14 Oct 2021 12:53:42 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 19ECrgTT045048 for ruby@FreeBSD.org; Thu, 14 Oct 2021 12:53:42 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ruby@FreeBSD.org Subject: [Bug 258108] devel/ruby-gems: Update to 3.2.26 (Fixes for Ruby 3.0) Date: Thu, 14 Oct 2021 12:53:42 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-qa, patch, regression X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: tj+freebsd_ports@a13.fr X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ruby@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: attachments.isobsolete attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: FreeBSD-specific Ruby discussions List-Archive: https://lists.freebsd.org/archives/freebsd-ruby List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ruby@freebsd.org X-BeenThere: freebsd-ruby@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D258108 Thibault Jouan changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #228666|0 |1 is obsolete| | --- Comment #13 from Thibault Jouan --- Created attachment 228695 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D228695&action= =3Dedit update to 3.2.29 - with new plugins system handling (In reply to Yasuhiro Kimura from comment #11) > I tried your patch but it causes plist error as following if I build > rubygem ports. Thank you for testing the patch and your feedback. With that version of the patch, this error is expected. I didn't fully understand the issue at the time, but I worked on it and made progress. Here are my notes (full notes in the patch) about this specific issue: RubyGems reworked the plugins system (see upstream 27d786e8). There isn't a lot of info, but by looking at upstream change f5bd2fe0 we can guess that the idea is to generate wrappers in the new "global" plugins directory (${GEMS_BASE_DIR}/plugins) with code to require the actual plugin in the gem own directory. For example with the `yard' gem (`textproc/rubygem-yard' port): % cat /usr/local/lib/ruby/gems/2.7/plugins/yard_plugin.rb require_relative '../gems/yard-0.9.26/lib/rubygems_plugin.rb' We handle plugins like extensions: if the gem has no plugin, we remove the empty directory at the end of `do-install' target; if the gem has a plugin, we add it to the plist at the end of `gem-autoplist' target. Regarding the last part, in `gem-autoplist' target of `Mk/Uses/gem.mk' file, I kept the usage of find but there is only *one* file to find, maybe the path can be derived from the port name: with port `yard' path is `plugins/yard_plugin.rb'. But I'd need to check for special cases. With the new attached patch, the "new" plugin wrapper is automatically included in the plist, gets in the package built from the port, and RubyGems loads it successfully (I only tested with yard however for now). --=20 You are receiving this mail because: You are the assignee for the bug.=