Re: Fw: Re: JH7110 dwc-eqos MAC support

On 3/30/25 06:08, JMT Sihvola wrote:
> 
> 
>> Sent: Sunday, March 30, 2025 at 10:04 AM
>> From: "JMT Sihvola" <jsihv@gmx.com>
>> To: "Rich Dunkle" <rdunkle@smallcatbrain.com>
>> Subject: Re: JH7110 dwc-eqos MAC support
>>
>>> Sent: Sunday, March 30, 2025 at 7:22 AM
>>> From: "Rich Dunkle" <rdunkle@smallcatbrain.com>
>>> To: freebsd-riscv@freebsd.org
>>> Subject: JH7110 dwc-eqos MAC support
>>>
>>> I was wondering about support for this eqos ethernet driver on the JH7110.
>>> I see there is a review:  https://reviews.freebsd.org/D45600
>>> --but appears stalled.
>>> I was studying the code in the review and cannot find one include:
>>> sys/riscv/starfive/starfive_if_eqos.c
>>> line 34:   #include "if_eqos_if.h"
>>
>  
> Yes, JH7110 is my first kernel project and I didn't add those files
> for some reason.
>  
> I realized this mistake some time ago but I haven't updated the patch
> since I thought it's probably not the only thing that needs to be changed
> if the patch gets reviewed one day.
>  
> But now when somebody got interested I could update the patch next week.
>  
> the ethernet patch requires these lines to sys/riscv/starfive/files.starfive:
> riscv/starfive/starfive_if_eqos.c	optional eqos 
> dev/eqos/if_eqos.c			optional eqos 
> dev/eqos/if_eqos_if.m			optional eqos 
>  
> and these lines to sys/riscv/conf/GENERIC or sys/riscv/conf/std.starfive:
> device		mcommphy
> device		eqos
>  
> The pending GPIO patch is likely to be required first
>  
> -j. sihvola
> 
> 

The timing of this inquiry is good, as I was just looking at the change
again on Friday. The review indeed stalled, but IMO it is pretty much ready.

I have made some tweaks locally, and I will note these in the review,
but unless there is an objection I will probably just merge it soon.

Mitchell