From nobody Wed Feb 26 19:08:06 2025 X-Original-To: rc@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Z33s264GGz5nhqM for ; Wed, 26 Feb 2025 19:08:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Z33s25c2Kz3RsQ for ; Wed, 26 Feb 2025 19:08:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740596886; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q7PfIQgrdT6jg85lJ1WGb7GbPVrXSdIhtOTKDFFWk4k=; b=iQJq8NAhTr1er3ROWDqKxcowddo6PER3Xu+PjHfanXS64x8oOVf18O9rQ0XAP3QEXY1h13 7S61aquVKTCvTbZU5YXidpKBvnUisKygVwt3sVt2r5SZP1mof8uifwjyvkg2RrkhUivDra ysW6sAiw0BudX6WoWuynrA2QLeey2ktYAqZVm3AQIju37Z7c3T1Z8oeY35kP56QQggD2qN TRk8tBv2mkNzJZe1VI1cL11eXTEshYGsIyfbBtR1h8tTx9de2wL9OdltZEd2cKduiFfIPw DI8k+UTEOV0kyWivo/Lg2LanICofrJnB6Jk+Ik6i0Ob0TbqJtk872+H/O6Y1aQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1740596886; a=rsa-sha256; cv=none; b=qXv8a+3HvTbkuDNy1WUdv78tC5/qAdhRBE8A+3/B0+Bc4f3tSgt9q+RVrO6rlWid/+EBF8 qJl1Ri3U8lhuaJjMxkfasT0UOYw79ELRMYShIIG69Y2G2CipLS8JamlVTACc4jr5qLl5WW snml1k8YlZ4Mg+8ANPT1uX2XmDUKwGjDRi81IjivWqsmR7IDA4TCVbl64WndWZaoWP6ZVY 0GrrZOCCgI0E2A2b1/AnBN1ZOoFqVvMxX99i9AVD90piK4YtAyVzoL5YhOhfLgn2l3woT7 tNm2tVh6/Ba1eWECL9QH8drEOEeVSMO+6rTJYfGGnfn67WRmRnhlZsdmXiaVQw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740596886; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q7PfIQgrdT6jg85lJ1WGb7GbPVrXSdIhtOTKDFFWk4k=; b=NNidJLbFQ6FcTD/uPMcRy+hl2pWj3spPm6XnwGFtvNWdChEABI6ybp4qLzxtJS7HpV5ObM aePoOYazVQ+N5dphif8k8EctBmKwnmp59cNpdhN9BITeAauD7rvMqmangRW6n8JbLMv15y fZGsVO5QTqZVU0bAt0kkFpVQnLqIXFZmyqFG/ZLeq0hC5v+sBz1EJOPfPjfG7XE6Jp9oBr oGElzy0zq4NYc+11vG1QE5k5WHnGnqVSzoBIJwRrLaQwTAbhbuK1/BKSZc0ozsJUhrAAJG gRq9duDMnJ5AYD1nhuagq71l1fTfsLRzth9nbwY4WQTB3N+0ULAg7sE/XGhWIw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Z33s2588Bz1P2f for ; Wed, 26 Feb 2025 19:08:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 51QJ86DT017542 for ; Wed, 26 Feb 2025 19:08:06 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 51QJ86ph017540 for rc@FreeBSD.org; Wed, 26 Feb 2025 19:08:06 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: rc@FreeBSD.org Subject: [Bug 284865] IPFW syntax errors in /etc/rc.firewall Date: Wed, 26 Feb 2025 19:08:06 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: conf X-Bugzilla-Version: 13.4-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: jlduran@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: rc@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussion related to /etc/rc.d design and implementation List-Archive: https://lists.freebsd.org/archives/freebsd-rc List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-rc@freebsd.org Sender: owner-freebsd-rc@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D284865 Jose Luis Duran changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jlduran@FreeBSD.org --- Comment #1 from Jose Luis Duran --- (In reply to gotnull from comment #0) You should not get an error when parsing rc.firewall. Looking at the code, both options are valid, and should yield the same resu= lt, (sbin/ipfw/ipfw2.c): { "icmptype", TOK_ICMPTYPES }, { "icmptypes", TOK_ICMPTYPES }, This alias was added in https://cgit.freebsd.org/src/commit/?id=3D0a7197a83c3c3833cc0cb862ee6483083= 09fdc6b The bug is perhaps in the man page, we should document this alias as well, while here we could use the plural form when there are many ICMP (4/6) type= s in /etc/rc.firewall. --=20 You are receiving this mail because: You are the assignee for the bug.=