Re: virtio drivers not being found on RELENG_14 from Apr 7th ? (solved)

From: mike tancsa <mike_at_sentex.net>
Date: Tue, 08 Apr 2025 18:46:56 UTC
On 4/8/2025 1:39 PM, Andrew Turner wrote:
>> On 8 Apr 2025, at 18:13, mike tancsa <mike@sentex.net> wrote:
>>
>>
>> On 4/8/2025 12:24 PM, mike tancsa wrote:
>>> I updated one of my build VMs to today's kernel and the VM no longer sees the virtio drivers.  The previous kernel was from late March. I am going to try and narrow it down. But anyone have any ideas what it might be ?
>>>
>>> diff between boot verbose below.
>>>
>> Doing a reset back to
>>
>> root@build14:/usr/src # git reset --hard e431b38b0f77a6deff9f6f214fe520b689c38bd2
>> HEAD is now at e431b38b0f snd_hda: Patch Framework 16 AMD
>> root@build14:/usr/src #
>>
>> It works
>>
>> If I forward to
>> root@build14:/usr/src # git reset --hard 423362c3d8d6a236c49e7f9d667032c05d5c170d
>> HEAD is now at 423362c3d8 pci: Only claim to support PCI ASPM on x86
>> root@build14:/usr/src #
>>
>> it fails  It seems to be the commits by andrew@FreeBSD.org ?
> It looks like I forgot to tell Colin to also MFC b714eacb790551f35de03831b88ad7b7e1502102 (acpi: Pass the correct device to acpi_pcib_osc) when he MFCd my other PCI changes. I’ll push the MFC as soon as a build sanity check passes.

Thanks Andrew for the quick fix!

     It looks like it behaved differently on different hardware too.  On 
a RYZEN hypervisor (ubuntu 20.x LTS), it seems to be OK. On Intel, with 
KVM from Ubuntu 22.04.5 LTS it seems to have the problem.  But with the 
MFC, both work as expected again.  Thanks again!


# git log
commit ddf0b5666bf550392a84847b76e3738693937a38 (HEAD -> stable/14, 
origin/stable/14)
Author: Andrew Turner <andrew@FreeBSD.org>
Date:   Fri Jan 3 16:03:31 2025 +0000

     acpi: Pass the correct device to acpi_pcib_osc

     Fix a copy-and-paste error in acpi_pcib_request_feature where the
     child device was passed into acpi_pcib_osc rather than the pcib
     device.

     Reviewed by:    garga, jhb
     Fixes:  ba1904937d9a ("acpica: Extract _OSC parsing to a common file")
     Sponsored by:   Arm Ltd
     Differential Revision:  https://reviews.freebsd.org/D48285

     (cherry picked from commit b714eacb790551f35de03831b88ad7b7e1502102)


     ---Mike