[Differential] D35513: [WIP] Adding devel/py-threadpoolctl

Go to: [ bottom of page ] [ top of archives ] [ this month ]

From: koobs (Kubilay Kocak) <phabric-noreply_at_FreeBSD.org>
Date: Sat, 18 Jun 2022 03:06:33 UTC

koobs added inline comments.

INLINE COMMENTS

> Makefile:22
> +
> +USES=		python:3.8+
> +NO_ARCH=	yes

Upstream declares requires-python = ">=3.6" (capping at 3.9). Match upstream version support declarations as closely as possible given our current `USES=python:<version-spec>` syntax. 3.6-3.9 is fine here, unless upstream tests with and the tests pass with 3.10 too

> Makefile:32
> +	${PYTHON_CMD} -m installer --destdir="${STAGEDIR}" dist/*.whl)
> +
> +.include <bsd.port.mk>

Upstream provides tests in their sources. If these are not packaged in the PyPI sdist, feel free to `USE_GITHUB` in the meantime after asking upstream to ship them there.

Should be able to:

  do-test:
  cd ${WRKSRC} && ${PYTHON_CMD} -m pytest -v -rs -o addopt=

> pkg-plist:7
> +%%PYTHON_SITELIBDIR%%/threadpoolctl-3.1.0.dist-info/WHEEL
> +%%PYTHON_SITELIBDIR%%/threadpoolctl.py

Are pyc|pco objects created at first runtime for this file? If so, these will be orphans on uninstallation

REPOSITORY
  R11 FreeBSD ports repository

CHANGES SINCE LAST ACTION
  https://reviews.freebsd.org/D35513/new/

REVISION DETAIL
  https://reviews.freebsd.org/D35513

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: thierry, yuri, emaste_freebsdfoundation.org, wen
Cc: koobs, freebsd-python-list, #python