From nobody Tue Apr 26 23:58:57 2022 X-Original-To: python@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 5F16519924DC for ; Tue, 26 Apr 2022 23:58:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KnzPF1XGLz3MSK for ; Tue, 26 Apr 2022 23:58:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 110FA19338 for ; Tue, 26 Apr 2022 23:58:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 23QNwv5K021553 for ; Tue, 26 Apr 2022 23:58:57 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 23QNwvUm021552 for python@FreeBSD.org; Tue, 26 Apr 2022 23:58:57 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: python@FreeBSD.org Subject: [Bug 263580] net/py-pyzmq: Builds with Cython when it is installed Date: Tue, 26 Apr 2022 23:58:57 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: novel@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback+ X-Bugzilla-Changed-Fields: short_desc cc bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: FreeBSD-specific Python issues List-Archive: https://lists.freebsd.org/archives/freebsd-python List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-python@freebsd.org X-BeenThere: freebsd-python@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1651017537; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nuKbvl+U7qjwq1iYGqKt/+HRPEGLQgmQpQJwE1zWCMQ=; b=vKbStC96Llp51n/oxdUgUdQZKhJTRis4ne+4pXpU3Oje4MlLzc5n1upM9OopIEz08B4d39 0kl9BVSlPZiA0yEhkyLpQ93EqWyoNUrU9uURQ39J1OFnVu6HutOn+I0VcTDM4t0eH3/W0N r2fiJuLoda/wdvxCNo5fDBVv90gkWKZgJ5MTUJQEPji1Tq2PJQd/XelRuBaUNN1gXJzCl/ DmLE6ivGC2g72cl+m+DQv2HwzVhIzbl6zYav385xtHGmwhcPIOxA18Zy+KMCO4FIk558QY X8gNcbd+9fov6fXVnULxP/fZ/jeGglILrJ7dB2wOOzXAdRYJqUVVx4g6KPE0uQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1651017537; a=rsa-sha256; cv=none; b=oc+n/QF2upEhAOf8sWwQFtHYDh1mKciqhvWCaxxmC+C16zp1gvmzsNxtZhsUdiEceZTixk uCZl1VgtjBxkvWn3RZOkIMQUQhQWP9VpT/viqv6zEtqzuL28eeJQzyukuqQbOtHfNZqZDZ c3NHsoLg1vZZ0BUlWFyYNxAC4uOOPeeDVWfKIz+MSPJj5/YRTCrt4DPTPxl1Bjppd8c2Vt UauZoDB8Dxgy/ScyEISiJ5Eit6ox0iTmeefCUHp2eYIMAMd3ziWxzK3TihZDVyTf2LRmqe WKD5DVAC4S1IaJx56m2AB7woh0BrvmcSuebt1pUyeKOX53eeyTOFd/dWEa5F8w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D263580 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|net/py-pyzmq: add |net/py-pyzmq: Builds with |dependency on cython |Cython when it is installed CC| |python@FreeBSD.org Status|New |Open --- Comment #2 from Kubilay Kocak --- The upstream sdist (PyPI tarball creation) process has a process for checki= ng and ensuring cython files are compiled to C files prior to upload: class CheckSDist(sdist): """Custom sdist that ensures Cython has compiled all pyx files to c.""" Unfortunately the check for Cython is not made conditional: try: import Cython However later in the setup.py, the following only adds (registers) and actu= al cython dependency if socket.c doesnt exist (indicating cython sources havent been compiled) if not os.path.exists(os.path.join("zmq", "backend", "cython", "socket.c")): # this generally means pip install from git # which requires Cython setup_args.setdefault("setup_requires", []).append( f"cython>=3D{min_cython_version} Adding a cython dependency to the port is spurious, and a better approach is either: 1) merge/move the import line to within the source file check, so both the = try import and the registration are conditional, and send upstream, OR 2) hack: remove the try/import/exception block. As far as Python version support goes, the standard is to declare version support against the versions upstream CI's and passes tests against. If they are testing with Cython builds, that means their sdist pipeline is untested, which is problematic and should be reported too. --=20 You are receiving this mail because: You are on the CC list for the bug.=