[Bug 263353] lang/python3*: Fails to link with LTO: Python includes unconditionally adds -g to --with-lto

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263353

Matthias Andree <mandree@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|needs-patch                 |

--- Comment #6 from Matthias Andree <mandree@FreeBSD.org> ---
koobs@, 

we cannot work like that and leave ports regressed and non-building just
because someone wants to have the perfect fix, possibly sitting the fix out
until the cows come home (*)

I don't buy your PGO consideration: What piece of the code would enable PGO
anyways? The configure stage suggests to --enable-optimizations (which we do
not do) to enable PGO, "make configure" is sufficient to see that. We don't see
the regression that prompted the upstream change, and given the nature of the
latter, I contend that it's trying to downstream (as in Python) fix compiler
bugs.  And now you're talking to me about unfitting patches.

I fail to see what benefit -ftlto=thin would bring, because it does not take
any of your objectsion away; but feel free to run it and see how far it reduces
size of the wkrdir and peak linker memory use, and if it really achieves the
same goals, commit before maintainer timeout. I am not wasting more time.

(*) I do not care about minimal deviation from upstream on a life support
branch (which is what Python 3.7 and 3.8 are, security fix only).

The build regression is real, and the easy fix would have been to just revert
the offending commit and possibly bump PORTEPOCH, which I haven't done although
I could perfectly have invoked the "fix broken build" blanket just as well.

We can always refine fixes later, but barring a better solution in due time
(end April), we need a solution and we need to get the short-term fix in place
and get it out of the (time-)critical path.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.