[Bug 246328] [RESTORE] net-p2p/nicotine-plus: Graphical client for the Soulseek file sharing network

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246328

Kubilay Kocak <koobs@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |feature, needs-patch,
                   |                            |needs-qa
           Severity|Affects Many People         |Affects Only Me
              Flags|                            |maintainer-feedback?(menelk
                   |                            |ir@itroll.org)
                 CC|                            |python@FreeBSD.org
            Summary|[RESTORE]                   |[RESTORE]
                   |net-p2p/nicotine-plus: New  |net-p2p/nicotine-plus:
                   |maintainer                  |Graphical client for the
                   |                            |Soulseek file sharing
                   |                            |network

--- Comment #32 from Kubilay Kocak <koobs@FreeBSD.org> ---
Hi Daniel, thanks for updating the patch

A few review items:

COMMENT should match upstream setup.py:description modulo portlint
requirements:

    setup.py: description="Graphical client for the Soulseek file sharing
network",

Use MASTER_SITES=CHEESESHOP if a Python package is registered on PyPI, unless
there is a compelling (temporary) case not to. [1]

Use PKGNAMEPREFIX, unless there is a compelling case not to. [2]

A dd python as a secondary category, unless there is a compelling reason not
to. [3]  

Don't restrict USES=python:<version-spec> (currently only 3.8). <version-spec>
is declarative ("supports" <version-spec> versions) not imperative ("use"
<version-spec> versions). Upstream defines python_requires='>=3.5', (setup.py)
[4]

All dependency <version-spec>'s should be defined as completely and accurately
as possible to match upstreams declarations [5] . One example here is: 

  setup.py: install_requires=['PyGObject>=3.18'],

Related: Where are the dependencies for mutagen/miniupnpc declares?

GH_* defaults to PORTNAME and PORTVERSION already, and are unnecessary:

  GH_PROJECT=   ${PORTNAME}
  GH_TAGNAME=   ${PORTVERSION}

Python ports should use autoplist and (concurrent where necessary) [6] unless
there is a compelling reason not to


Related, USE_PYTHON=concurrent must be used when a Python port installs files
that are not Python-version specific in shared locations [7]. This one does:

  bin/nicotine
  share/applications/*
  share/doc/*
  share/icons/*
  share/locale/*
  share/man/*
  share/metainfo/*

The default concurrent files list may not pick up some of the above, so you may
need to add entries to UNIQUE_FILES / UNIQUE_DIRS or related variables. See:
/usr/ports/Mk/Uses/python.mk:concurrent and /usr/ports/Mk/Uses/uniquefile.mk

As far as what else would be good to progress this port, confirmation of QA
(portlint and poudriere) [8] would be great. Test with both the default and a
non-default Python version

If you need help with respect to this port, porting in general or other Python
ports, just jump on our #freebsd-ports and/or #freebsd-python IRC [9] channels.

[1] https://wiki.freebsd.org/Python/PortsPolicy#MASTER_SITES
[2] https://wiki.freebsd.org/Python/PortsPolicy#PKGNAMEPREFIX
[3] https://wiki.freebsd.org/Python/PortsPolicy#CATEGORIES
[4] https://wiki.freebsd.org/Python/PortsPolicy#USES.3Dpython
[5] https://wiki.freebsd.org/Python/PortsPolicy#Dependencies
[6] https://wiki.freebsd.org/Python/PortsPolicy#USE_PYTHON_Features
[7] https://wiki.freebsd.org/Python/PortsPolicy#concurrent
[8] https://docs.freebsd.org/en/books/porters-handbook/testing/
[9] https://wiki.freebsd.org/IRC/Channels

-- 
You are receiving this mail because:
You are on the CC list for the bug.