From nobody Mon Jul 26 01:08:47 2021 X-Original-To: python@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id F12EB12BFC3D for ; Mon, 26 Jul 2021 01:08:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GY1yl6C6bz53YW for ; Mon, 26 Jul 2021 01:08:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id BAC2A5AC2 for ; Mon, 26 Jul 2021 01:08:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 16Q18ltB044041 for ; Mon, 26 Jul 2021 01:08:47 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 16Q18lsm044040 for python@FreeBSD.org; Mon, 26 Jul 2021 01:08:47 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: python@FreeBSD.org Subject: [Bug 257421] [NEW PORT] textproc/py-charset-normalizer: Universal Charset Detector. Open, modern alternative to Chardet Date: Mon, 26 Jul 2021 01:08:47 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: feature, needs-patch, needs-qa X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: keywords bug_status cc flagtypes.name short_desc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: FreeBSD-specific Python issues List-Archive: https://lists.freebsd.org/archives/freebsd-python List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-python@freebsd.org X-BeenThere: freebsd-python@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D257421 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |feature, needs-patch, | |needs-qa Status|New |Open CC| |0xdutra@gmail.com, | |python@FreeBSD.org Flags| |maintainer-feedback?(0xdutr | |a@gmail.com) Summary|[New Port] |[NEW PORT] |textproc/py-charset-normali |textproc/py-charset-normali |zer: Package for encoding & |zer: Universal Charset |language detection |Detector. Open, modern | |alternative to Chardet --- Comment #1 from Kubilay Kocak --- Thank you for submitting a new port Gabriel. Some review review items: - Match upstream short name / summary / show description, modulo portlint requirements. Suggested COMMENT change is this issues current summary (upda= te if required). - Match USES=3Dpython version spec to upstream (setup.py:REQUIRES in this = case) - Upstream defines no RUN_DEPENDS (install_requires) (setup.py: REQUIRED = =3D []) Be careful just copying requirements.txt. Upstream should have this as a test_requirements.txt and/or (better): extras_require [ devreqs =3D { ... , ... } ] so people can just `pip install charset-normalizer[devreqs]` - Upstream defines an extras_require, add an OPTION for this, named appropriately (the feature it provides) - The package provides tests. Add TEST_DEPENDS and do-test target accordin= gly. Tip: For pytest based tests, use the following invocation, which overrides = any 'extra stuff' set in setup.cfg:[tool:pytest] and other places. This will re= move the need for pycov, in this case: do-test: @cd ${WRKSRC} && ${PYTHON_CMD} -m pytest -v -rs -o addopts=3D Have a run through our Python Packaging guidelines, and confirm if the test suite and poudriere tests pass: * https://wiki.freebsd.org/Python/PortsPolicy https://docs.freebsd.org/en/books/porters-handbook/testing-poudriere.html --=20 You are receiving this mail because: You are on the CC list for the bug.=