From nobody Tue Aug 17 07:56:03 2021 X-Original-To: python@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id E291A174C153 for ; Tue, 17 Aug 2021 07:56:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GpjyW60xjz3vQP for ; Tue, 17 Aug 2021 07:56:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id B723919D56 for ; Tue, 17 Aug 2021 07:56:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 17H7u3HR013106 for ; Tue, 17 Aug 2021 07:56:03 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 17H7u36N013105 for python@FreeBSD.org; Tue, 17 Aug 2021 07:56:03 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: python@FreeBSD.org Subject: [Bug 256558] lang/python3[89]: fix build WITH_DEBUG Date: Tue, 17 Aug 2021 07:56:03 +0000 X-Bugzilla-Reason: CC AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-qa X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: loader@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: python@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: FreeBSD-specific Python issues List-Archive: https://lists.freebsd.org/archives/freebsd-python List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-python@freebsd.org X-BeenThere: freebsd-python@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D256558 Fukang Chen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |loader@FreeBSD.org --- Comment #7 from Fukang Chen --- (In reply to Kubilay Kocak from comment #1) It was introduced by this commit on the 3.8 branch, EXT_SUFFIX now contains ${SOABI} on FreeBSD: https://github.com/python/cpython/commit/b01091a3e71e6636d2df4db45920e820cd= f7df3b commit a44ce6c9f725d336aea51a946b42769f29fed613 Author: Matti Picus Date: Sun Dec 20 04:56:57 2020 +0200 bpo-42604: always set EXT_SUFFIX=3D${SOABI}${SHLIB_SUFFIX} when using configure (GH-23708) Now all platforms use a value for the "EXT_SUFFIX" build variable deriv= ed from SOABI (for instance in FreeBSD, "EXT_SUFFIX" is now ".cpython-310d= .so" instead of ".so"). Previously only Linux, Mac and VxWorks were using a value for "EXT_SUFFIX" that included "SOABI". Co-authored-by: Pablo Galindo diff --git a/configure.ac b/configure.ac index 445dae1..ee5573c 100644 --- a/configure.ac +++ b/configure.ac @@ -4786,12 +4786,7 @@ if test "$Py_DEBUG" =3D 'true' -a "$with_trace_refs"= !=3D "yes"; then fi AC_SUBST(EXT_SUFFIX) -case $ac_sys_system in - Linux*|GNU*|Darwin|VxWorks) - EXT_SUFFIX=3D.${SOABI}${SHLIB_SUFFIX};; - *) - EXT_SUFFIX=3D${SHLIB_SUFFIX};; -esac +EXT_SUFFIX=3D.${SOABI}${SHLIB_SUFFIX} AC_MSG_CHECKING(LDVERSION) LDVERSION=3D'$(VERSION)$(ABIFLAGS)' SOABI is "cpython-38d" and configure argument "--with-pydebug" adds "d" to = the ABIFLAGS: https://github.com/python/cpython/blob/v3.8.11/configure.ac#L4693 4693 SOABI=3D'cpython-'`echo $VERSION | tr -d .`${ABIFLAGS}${PLATFORM_TRIPLET:+-$PLATFORM_TRIPLET} https://github.com/python/cpython/blob/v3.8.11/configure.ac#L1231-L1249 1231 # For calculating the .so ABI tag. 1232 AC_SUBST(ABIFLAGS) 1233 ABIFLAGS=3D"" 1234=20=20 1235 # Check for --with-pydebug 1236 AC_MSG_CHECKING(for --with-pydebug) 1237 AC_ARG_WITH(pydebug, 1238 AS_HELP_STRING([--with-pydebug], [build with Py_DEBUG defined]), 1239 [ 1240 if test "$withval" !=3D no 1241 then 1242 AC_DEFINE(Py_DEBUG, 1, 1243 [Define if you want to build an interpreter with many run-time checks.]) 1244 AC_MSG_RESULT(yes); 1245 Py_DEBUG=3D'true' 1246 ABIFLAGS=3D"${ABIFLAGS}d" 1247 else AC_MSG_RESULT(no); Py_DEBUG=3D'false' 1248 fi], 1249 [AC_MSG_RESULT(no)]) disttuiles build_ext.py gets the extension filename ext_suffix from EXT_SUF= FIX: https://github.com/python/cpython/blob/v3.8.11/Lib/distutils/command/build_= ext.py#L675-683 675 def get_ext_filename(self, ext_name): 676 r"""Convert the name of an extension (eg. "foo.bar") into t= he name 677 of the file from which it will be loaded (eg. "foo/bar.so",= or 678 "foo\bar.pyd"). 679 """ 680 from distutils.sysconfig import get_config_var 681 ext_path =3D ext_name.split('.') 682 ext_suffix =3D get_config_var('EXT_SUFFIX') 683 return os.path.join(*ext_path) + ext_suffix --=20 You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.=