From nobody Sun Feb 23 07:32:35 2025 X-Original-To: freebsd-ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Z0wYz6JRdz5ph16 for ; Sun, 23 Feb 2025 07:32:39 +0000 (UTC) (envelope-from rnagy@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Z0wYz3nzLz3PHQ; Sun, 23 Feb 2025 07:32:39 +0000 (UTC) (envelope-from rnagy@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740295959; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0kxVw+C5ZvlwRFcWJofeuhg4J/Nh1Qb8ZguqbtdJJYU=; b=eAYwGCEOBalNz7rMurnrFKiMZiOPkDOD5xq4uDipf8Aol8uBxneNa5Opud4xfPET4sm8Mb 1lZlLS04X9i7KX0NqLgwVxMPkN+bTkV4L7ob+lUrwIPnV58x7Kopqdi0ZJa2DFpqEANcdY zDQmWykGwby+AyZsAxinR1qXqa4+nbqFBv1ieh/Wh7OV/wZxypeOkxE84NXPhWC2VuYwMv 6DBZHPeEZ+HJEarmTJMbyHV363g7bybtg1j61lc3mobefVArfGyhufPbJR2O3ZBlW1yw5F 6fU8UHO7ztqL4dQOkVZu0bp0DK+GoDi54q0QBMLd7PScliq4JPFaEfYDP1p8CQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1740295959; a=rsa-sha256; cv=none; b=FfatLZLfNHD41m/ZzDvOE8algF8Rw9o6yVTJb927L8T1ySt8ff4mgJfQhMW3jQk5HngKs4 ScG45ycm9H8mMH6dOOhZ74Gb7QMqjaoyhaZomNPuufK6aCSfSI5CxFDVVXV1Miwo2Od7lW BxtVENCd3ik1He8XU0guKKMtTpzpPElFFdv1arU6Utq/anBRBvpp1e5tPp3NUJB4FbP1Ig Pfja0fxQ2TKW02ur0tHF9M4qeTlfqKybldeOXNNROOZWPK2CeJfppdLDV+unk3RClOOGse BQ0kCV9e2QGajlmQ/8UiD6ST+zmDo32GkM4g1cS/R4nvPAW0fqETzC7loYG6xQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740295959; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0kxVw+C5ZvlwRFcWJofeuhg4J/Nh1Qb8ZguqbtdJJYU=; b=eC3Z/MulD5gcbPrChg+HeV8rYz1mhKZbIsqQ9JV6XvSC4BRFjWIOd2awMjrHcBf8S+0siF WROpgRDcgxKLd0T1Pt32bRxaLC5IZdX7ri4vofFmhS1Pmb/qBY41RMovwU7eaKNtP0uiPw 2AlqX3uYrEl209OLvPJbUKMvGwdryf2njSLv/vVq9EO4S3aPkB0Aq/4vWcdC70/gth7oer ykZOW7SxOA1DYBOYYF0wgdQI3OeaYjvFMFiAadTVx85HCEjmWIp1V0hPFlKOxHtGuEtMaN lqiwCKwU5H7htWx3oOrGsZMxPxBX0GPlWft1z4jREjjmkj6HV9yeSPsZ+4lBcA== Received: from freebsd.org (nerd.hu [84.2.34.134]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA512) (Client did not present a certificate) (Authenticated sender: rnagy/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Z0wYy5t7Gz1LKB; Sun, 23 Feb 2025 07:32:38 +0000 (UTC) (envelope-from rnagy@freebsd.org) Date: Sun, 23 Feb 2025 08:32:35 +0100 From: Robert Nagy To: Mark Millard Cc: Hiroki Tagato , "Jason E. Hale" , FreeBSD Mailing List Subject: Re: aarch64 electron build failure: fatal error: 'asm/hwcap.h' file not found; mark as BROKEN_aarch64 until fixed? Message-ID: References: <65119a1e-a2ba-489c-82ca-0a262011e99b@FreeBSD.org> <7a183e3e-e6e4-4664-9c42-eb7e3b976fd5@FreeBSD.org> <696ec5fb-4cf0-4bed-bb3f-7d328766cef8@FreeBSD.org> <1F0CACC2-777A-478C-A870-C08D842C7BCC@yahoo.com> List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-ports@freebsd.org Sender: owner-freebsd-ports@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1F0CACC2-777A-478C-A870-C08D842C7BCC@yahoo.com> On 22/02/25 06:53 -0800, Mark Millard wrote: > [Note: I've added rnagy@ for the new www/chromium note.] > >>>> QUOTE > >>>> archivers/libunrar: Support crc and crypto flags on aarch64 > >>>> If CPU flags crc or crytpo are set, e.g. -march=armv8-a+crc+crypto, build would fail with missing headers because this was only implemented for glibc and Apple. > >>>> END QUOTE > >>>> > >>>> I generally have -mcpu=cortex-a76 involved for my aarch64 builds for > >>>> the primary machines. That would mean that crc and crypto would be > >>>> impicitly enabled. > > With archivers/libunrar and devel/electron3[23] fixed for > build with crc and/or crypto flags for aarch64, that just > leaves www/chromium as failing to build for such contexts. > > www/chromium for aarch64 with -mcpu=cortex-a76 also failed > with: > > In file included from ../../third_party/unrar/src/crypt.cpp:1: > In file included from ../../third_party/unrar/src/rar.hpp:6: > ../../third_party/unrar/src/os.hpp:167:10: fatal error: 'asm/hwcap.h' file not found > 167 | #include > | ^~~~~~~~~~~~~ > 1 error generated. > > which is what the above fixed in libunrar and electron3[23] . Hi I am inclined to refuse such patches because first I do not see the point. Second, chromium is a gigantic project where each component already ammending cpu feature flags during the build depending on each subcomponent's needs. For e.g.: third_party/libyuv will either need +dotprod+i8mm or +sve2 depending on the file. Other components will use __attribute__((target("crypto"))) or others. Then I will not even talk about runtime issues that will definitely arise with custom cpu features. The actualy "fix" for this issue is to make the port completely ignore such override flags coming from any part of the system (make.conf, environment).