Re: thunderbird 128.4.0 build fail on -current

From: Jung-uk Kim <jkim_at_FreeBSD.org>
Date: Sun, 27 Oct 2024 06:57:24 UTC 
On 24. 10. 26., Michael Butler wrote:
> After the llvm19 import and today's thunderbird update, I ran into ..
> 
> In file included from /usr/ports/mail/thunderbird/work/ 
> thunderbird-128.4.0/comm/third_party/rnp/src/lib/crypto/ 
> cipher_botan.cpp:26:
> In file included from /usr/include/c++/v1/sstream:317:
> In file included from /usr/include/c++/v1/__ostream/basic_ostream.h:16:
> In file included from /usr/include/c++/v1/__system_error/error_code.h:18:
> In file included from /usr/include/c++/v1/__system_error/ 
> error_category.h:15:
> /usr/include/c++/v1/string:820:42: error: implicit instantiation of 
> undefined template 'std::char_traits<unsigned char>'
>    820 |   static_assert(is_same<_CharT, typename 
> traits_type::char_type>::value,
>        |                                          ^
> /usr/ports/mail/thunderbird/work/thunderbird-128.4.0/comm/third_party/ 
> rnp/src/lib/crypto/cipher_botan.cpp:83:65: note: in instantiation of 
> template class 'std::basic_string<unsigned char>' requested here
>     83 |     const char *cipher_string = id_str_pair::lookup(cipher_map, 
> cipher, NULL);
>        |                                                                 ^
> /usr/include/c++/v1/__fwd/string.h:23:29: note: template is declared here
>     23 | struct _LIBCPP_TEMPLATE_VIS char_traits;
>        |                             ^
> 1 error generated.
> 
>   .. which appears to be similar to the issue with devel/poco and fixed 
> in commit c55157301f317ab8166349340d4cc0765deaac12,

FYI, I filed PR282347 with the fix.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=282347

Jung-uk Kim