Re: www/chromium: 117.0.5938.62 build failed in 12.4-STABLE

In reply to: Tatsuki Makino : "www/chromium: 117.0.5938.62 build failed in 12.4-STABLE"
Go to: [ bottom of page ] [ top of archives ] [ this month ]

From: Tatsuki Makino <tatsuki_makino_at_hotmail.com>
Date: Fri, 15 Sep 2023 21:51:53 UTC

Tatsuki Makino wrote on 2023/09/15 12:27:
> -#elif BUILDFLAG(IS_POSIX) && !BUILDFLAG(IS_FREEBSD)
> +#elif BUILDFLAG(IS_POSIX) && __FreeBSD__ >= 13

With this rewrite, the build of 117.0.5938.62 on 12.x will succeed and can be used.
However, I think it is actually better to fix the following.

#elif BUILDFLAG(IS_POSIX)
    if (os_error != EAI_NONAME
#ifdef EAI_NODATA
&& os_error != EAI_NODATA
#endif
)
      err = ERR_NAME_RESOLUTION_FAILED;


Regards.