From nobody Fri Mar 03 16:13:09 2023 X-Original-To: freebsd-ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PStLm2KtGz3w52c for ; Fri, 3 Mar 2023 16:13:36 +0000 (UTC) (envelope-from janm@transactionware.com) Received: from mail3.transactionware.com (mail.transactionware.com [203.14.245.7]) by mx1.freebsd.org (Postfix) with SMTP id 4PStLk2mBFz3Pvt for ; Fri, 3 Mar 2023 16:13:34 +0000 (UTC) (envelope-from janm@transactionware.com) Authentication-Results: mx1.freebsd.org; dkim=none; spf=none (mx1.freebsd.org: domain of janm@transactionware.com has no SPF policy when checking 203.14.245.7) smtp.mailfrom=janm@transactionware.com; dmarc=none Received: (qmail 23759 invoked by uid 907); 3 Mar 2023 16:13:25 -0000 Received: from i5E8640CB.versanet.de (HELO smtpclient.apple) (94.134.64.203) (smtp-auth username janm, mechanism plain) by mail3.transactionware.com (qpsmtpd/0.84) with (ECDHE-RSA-AES256-GCM-SHA384 encrypted) ESMTPSA; Sat, 04 Mar 2023 03:13:25 +1100 Content-Type: text/plain; charset=utf-8 List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.400.51.1.1\)) Subject: Re: Possible regression in "make all-depends-list" From: Jan Martin Mikkelsen In-Reply-To: Date: Fri, 3 Mar 2023 17:13:09 +0100 Cc: freebsd-ports@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <3EE35107-6152-4144-AFBC-CBD61EECB1AF@transactionware.com> To: Gleb Popov X-Mailer: Apple Mail (2.3731.400.51.1.1) X-Spamd-Result: default: False [-1.49 / 15.00]; AUTH_NA(1.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.99)[-0.991]; MV_CASE(0.50)[]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; FROM_EQ_ENVFROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_NA(0.00)[]; R_SPF_NA(0.00)[no SPF record]; ASN(0.00)[asn:17559, ipnet:203.14.245.0/24, country:AU]; MIME_TRACE(0.00)[0:+]; MLMMJ_DEST(0.00)[freebsd-ports@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; ARC_NA(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; DMARC_NA(0.00)[transactionware.com]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Rspamd-Queue-Id: 4PStLk2mBFz3Pvt X-Spamd-Bar: - X-ThisMailContainsUnwantedMimeParts: N > On 2. Mar 2023, at 18:07, Jan Martin Mikkelsen = wrote: >=20 > On 2. Mar 2023, at 17:38, Gleb Popov wrote: >>=20 >> On Thu, Mar 2, 2023 at 6:35=E2=80=AFPM Jan Martin Mikkelsen >> wrote: >>>=20 >>> Running =E2=80=9Cmake all-depends-list=E2=80=9D on the hs-pandoc = port shows none of the dependencies listed in the USE_CABAL variable in = the Makefile. In the 2022Q2 branch, these dependencies were included. >>=20 >> USE_CABAL dependencies aren't port dependencies. These deps are >> compiled statically into the port, so from Ports Framework = perspective >> they are part of source files that make up the software being built. >=20 > Thanks, I misdiagnosed that one. The problem was some files were = discarded because of a bad checksum due to a Unicode translation issue. = (Byte order marks added to a UTF8 file.) >=20 >>> Running =E2=80=9Cmake all-depends-list=E2=80=9D on x11-wm/xfce4 = shows x11-servers/xorg-server as a dependency, but it does not include = all of the dependencies for xorg-server. For example: >>>=20 >>> xfce4 $ echo $PORTSDIR >>> /data/scratch/janm/p4/ports-2023.1/ports >>> xfce4 $ make all-depends-list | egrep 'xorg-server|libxcvt' >>> /data/scratch/janm/p4/ports-2023.1/ports/x11-servers/xorg-server >>> xfce4 $ cd ../../x11-servers/xorg-server >>> xorg-server $ make all-depends-list | egrep 'xorg-server|libxcvt' >>> /data/scratch/janm/p4/ports-2023.1/ports/x11/libxcvt >>>=20 >>> In the 2022Q2 branch the dependencies were included. >=20 > This case still seems to be a regression, as far as I can see. I tracked down the problem with the missing dependencies. This fixes it = for me. --- a/ports/Mk/Scripts/depends-list.sh 2023-03-02 11:46:56.000000000 = 1100 +++ b/ports/Mk/Scripts/depends-list.sh 2023-03-02 11:46:56.000000000 = 1100 @@ -76,7 +76,7 @@ ;; esac if [ -f ${d}/Makefile ]; then - if [ -n $f ]; then + if [ -n "$f" ]; then export FLAVOR=3D$f fi break Should I open a bug? Regards, Jan M.