From nobody Fri Jul 14 18:21:52 2023 X-Original-To: ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4R2fvc2xpsz4mfxC for ; Fri, 14 Jul 2023 18:22:04 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4R2fvc2nxRz4F2l; Fri, 14 Jul 2023 18:22:04 +0000 (UTC) (envelope-from eduardo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1689358924; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gpgmxX75z0M42L6nv6TS6SKR1SSqFUoagTTKWTToQso=; b=TtDT1cVoqKYJhrq6k+jdiBP2cgwJjgoRFk8jJAxhnJgOW5QSSOtsYYyx0OQBTDsqvLFJVK cpj1jz8rKCuqtqbXJk0+Jl+mh9BnYVzNJntPbhRlECMA6xZ9398U+q0Zwgoll5A9QUZA9b ln+VN+vvkNaUIsd3YZlScYrSfkZohmIMGcmqueDzC7nDwKGsGW7d5KVeh3juMC2/x5nPkd a7AEJFa9XH7jBcRl47DeXA/COUyG0/HwMZDwJMLSb6nNvYfcuDokswGhuk/Q8CVJKRnwzw 9Zz4NuUPamXrquhMF5lhaRoMGlN+fvoQ9rCE8eshp1JJG6eJlxdwFdnVSWvQoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1689358924; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gpgmxX75z0M42L6nv6TS6SKR1SSqFUoagTTKWTToQso=; b=VN7OIeuJ6R8Kk0GIKqbCfPPXgGXV+n+NYQ2DQQHolEbFBPWw2QCEcI75Jvx5eynRRFltC+ 4gX/cBnqGECyGpOWLHYkgY+Xgfyg9fwjFgYuSSiJW0/eI42CF6/988oKPcOWFTdL2Ks4Kc ExxAx0f/lQPEcnRuJE4Cq0DSnq43c43zbuGFUtJBpVHQ3d+nV0x5rRptj3Q2pGkC0SsEsU i51O9tOY2hhArG6CZ0SFUIbegibyhhG3UnlJyccJBx0MbV9Jl1doxn/adlID05B4+QODQe 6uBFIQnq4OIt1nPc/UM7vo6WlfkeMUQHtlrbHJFUYvsWQMR0weNDS5ILRUUBcQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1689358924; a=rsa-sha256; cv=none; b=gU4ipli9y70Dj+enVfOaidccnHq2xBqR+JAI75Km0pMCy3zO6f2n/jbN6AVaEnrfqcte+/ O9UMNKxxANbB8bIdwdT0Q2z113XBPj0UB5TAJ7d8KCmxmj7liUhBIRl99f2haB2hYDyImf 1PP6NAf7f5wTgiX5N4v8QsvtwRfs0ux3SyAuqMARxg9MmsjFZ7zNmwZ6mNwG9Yh0XiZZbm Eyp/AeeBU6P9Zna04soq/BOYpb0udfPSGho/F74gx6wj8mJA/KRBsj6ZdQkYfgmvxm0lq6 u5jTxSBnCNrQjb6heSsgCiU3On9S9CZGBZlQuY8mSu+65bfjSWhAyQnDzVtl+g== Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: eduardo) by smtp.freebsd.org (Postfix) with ESMTPSA id 4R2fvc1lhyzy3D; Fri, 14 Jul 2023 18:22:04 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-4039f7e1d3aso16494041cf.0; Fri, 14 Jul 2023 11:22:04 -0700 (PDT) X-Gm-Message-State: ABy/qLbII+AIkfh74l42XBUZ4RpP/ukCEytG+DrMz16uhjmQ4C/mdy4p pcmsQpeWdnU+9f0OhJOMe6WfxMbzN1WYrGJLGgE= X-Google-Smtp-Source: APBJJlGG5dKYpBYjYeE8zjDeEdqCLMRguqCnzerBpJSec7cA6mM92/n53cJdOmcVNxdbVTJndtP/FBvXmfUkTUubB/4= X-Received: by 2002:ac8:59c4:0:b0:403:9a00:2edb with SMTP id f4-20020ac859c4000000b004039a002edbmr7147584qtf.47.1689358923469; Fri, 14 Jul 2023 11:22:03 -0700 (PDT) List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org MIME-Version: 1.0 References: <88100d98-8d22-bb31-9181-dbbfb7c1a1f4@FreeBSD.org> In-Reply-To: From: Nuno Teixeira Date: Fri, 14 Jul 2023 19:21:52 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: graphics/xpaint updated to latest version To: Danilo Egea Gondolfo Cc: ports@freebsd.org Content-Type: multipart/alternative; boundary="000000000000881a24060076867a" X-ThisMailContainsUnwantedMimeParts: N --000000000000881a24060076867a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Could you please test latest commit? https://cgit.freebsd.org/ports/commit/?id=3Da4a9f75641c15079469454c885f94d7= a01953695 Thanks, Danilo Egea Gondolfo escreveu no dia sexta, 14/07/2023 =C3=A0(s) 17:20: > On 14/07/2023 13:40, Nuno Teixeira wrote: > > Oldest version used a patch: > ### > --- Makefile.in.orig 2021-08-14 14:31:15 UTC > +++ Makefile.in > @@ -1203,16 +1203,15 @@ messages.h: preproc > messages.h: preproc > ./preproc > messages.h > > -XPaint.ad: app-defaults > - $(CC) $(CFLAGS) substads.c -o substads > - cd app-defaults ; \ > +XPaint.ad: substads app-defaults > + (cd app-defaults ; \ > ../substads -appdefs \ > XPAINT_VERSION $(PACKAGE_VERSION) \ > XPAINT_SHAREDIR $(SHAREDIR) \ > XPAINT_PRINT_COMMAND "$(PRINT_CMD)" \ > XPAINT_PRINTER_LIST "$(PRINTER_LIST)" \ > XPAINT_POSTSCRIPT_VIEWER "$(POSTSCRIPT_VIEWER)" \ > - XPAINT_EXTERN_VIEWER "$(EXTERN_VIEWER)" > + XPAINT_EXTERN_VIEWER "$(EXTERN_VIEWER)") > cp -p app-defaults/out/XPaint XPaint.ad > > XPaint.ad.h: substads XPaint.ad > ### > > that I'm not using here. > Maybe this is related? Could you test it? > > Thanks > > Danilo Egea Gondolfo escreveu no dia sexta, > 14/07/2023 =C3=A0(s) 13:30: > >> On 14/07/2023 12:42, Nuno Teixeira wrote: >> >> Hello Danilo, >> >> My tests don't show that under poudriere with ALLOW_MAKE_JOBS=3Dyes on 2 >> parallel jobs. >> >> Should we wait for build packagers to see its results? >> >> Thanks, >> >> Danilo Egea Gondolfo escreveu no dia sexta, >> 14/07/2023 =C3=A0(s) 12:27: >> >>> On 14/07/2023 11:12, Nuno Teixeira wrote: >>> >>> Hello all, >>> >>> xpaint has been updated to lastest version. >>> Try out new features! >>> >>> I'm working on this update for more than 1 year but only yesterday I di= d >>> have the courage and nerves to build *all* releases until 3.1.4 as a wa= y to >>> understand the best way to "hack" configures and Makefiles and stuff. >>> >>> Please give it a try and tell me if anything needs to be fixed, etc. >>> >>> Cheers! >>> >>> >>> https://cgit.freebsd.org/ports/commit/?id=3D973a707c70478448af77004a07e= ab1f85c2f6757 >>> >>> -- >>> Nuno Teixeira >>> FreeBSD Committer (ports) >>> >>> Hi Eduardo, >>> >>> xpaint seems to not be multi-jobs-safe. The build will eventually fail >>> with this: >>> cd app-defaults ; \ >>> ../substads -appdefs \ >>> XPAINT_VERSION 3.1.4 \ >>> XPAINT_SHAREDIR /usr/local/share/xpaint \ >>> XPAINT_PRINT_COMMAND "lp -d" \ >>> XPAINT_PRINTER_LIST "lpstat -p | cut -d' ' -f 2" \ >>> XPAINT_POSTSCRIPT_VIEWER "evince" \ >>> XPAINT_EXTERN_VIEWER "display" >>> /bin/sh: ../substads: Text file busy >>> gmake[1]: *** [Makefile:1205: XPaint.ad] Error 126 >>> gmake[1]: *** Waiting for unfinished jobs.... >>> gmake[1]: Leaving directory >>> '/usr/ports/graphics/xpaint/work/xpaint-3.1.4' >>> >>> You might want to use MAKE_JOBS_UNSAFE=3Dyes. >>> >>> >>> >> >> -- >> Nuno Teixeira >> FreeBSD Committer (ports) >> >> That's because it's a race condition :) >> >> See: >> >> [danilo@capeta /usr/ports/graphics/xpaint]$ while : ; do make clean >> >/dev/null ; make >/dev/null 2>&1 ; if [ $? -ne 0 ] ; then echo 'Failed'= ; >> else echo 'Worked' ; fi ; done >> Worked >> Worked >> Failed >> Worked >> Worked >> Worked >> Worked >> Worked >> Worked >> Worked >> Worked >> Worked >> Failed >> Worked >> Worked >> Worked >> Worked >> Worked >> Worked >> Worked >> Failed >> Failed >> Worked >> Worked >> Worked >> Worked >> Worked >> > > > -- > Nuno Teixeira > FreeBSD Committer (ports) > > Yeah apparently that addresses the problem. But as you are using > USES=3Dautoreconf, you need to patch Makefile.am actually. > > This change seems to be enough: > > -XPaint.ad: app-defaults > +XPaint.ad: substads app-defaults > > --=20 Nuno Teixeira FreeBSD Committer (ports) --000000000000881a24060076867a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Could you please test latest commit?

Danilo Egea Gondolfo <= danilo@freebsd.org> escreveu no dia sexta, 14/07/2023 =C3=A0(s) 17:2= 0:
=20 =20 =20

On 14/07/2023 13:40, Nuno Teixeira wrote:

=20
Oldest version used a patch:
###
--- Makefile.in.orig =C2=A0 =C2=A02021-08-14 14:31:15 UTC
+++ Makefile.in
@@ -1203,16 +1203,15 @@ messages.h: preproc
=C2=A0messages.h: preproc
=C2=A0 =C2=A0 =C2=A0 =C2=A0 ./preproc > messages.h

-XPaint.ad: app-defaults
- =C2=A0 =C2=A0 =C2=A0 $(CC) $(CFLAGS) substads.c -o substads
- =C2=A0 =C2=A0 =C2=A0 cd app-defaults ; \
+XPaint.ad: substads app-defaults
+ =C2=A0 =C2=A0 =C2=A0 (cd app-defaults ; \
=C2=A0 =C2=A0 =C2=A0 =C2=A0 ../substads -appdefs \
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 XPAINT_VERSION $(PACKAGE_VERSION) \
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 XPAINT_SHAREDIR $(SHAREDIR) \
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 XPAINT_PRINT_COMMAND "$(PRINT_CMD)" \
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 XPAINT_PRINTER_LIST "$(PRINTER_LIST)" \
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 XPAINT_POSTSCRIPT_VIEWER "$(POSTSCRIPT_VIEWER)" \
- =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = XPAINT_EXTERN_VIEWER "$(EXTERN_VIEWER)"
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = XPAINT_EXTERN_VIEWER "$(EXTERN_VIEWER)")
=C2=A0 =C2=A0 =C2=A0 =C2=A0 cp -p app-defaults/out/XPaint XPaint.= ad

=C2=A0XPaint.ad.h: substads XPaint.ad
###

that I'm not using here.
Maybe this is related? Could you test it?

Thanks

Danilo Egea Gondolfo <danilo@freebsd.org&= gt; escreveu no dia sexta, 14/07/2023 =C3=A0(s) 13:30:

On 14/07/2023 12:42, Nuno Teixeira wrote:

Hello Danilo,

My tests don't show that under poudriere with ALLOW_MAKE_JOBS=3Dyes on 2 parallel jobs.

Should we wait for build packagers to see its results?

Thanks,

Danilo Egea Gondolfo <danilo@freebsd.org> escreveu no dia sexta, 14/07/2023 =C3=A0(s) 12:27:

On 14/07/2023 11:12, Nuno Teixeira wrote:

Hello all,

xpaint has been updated to lastest version.
Try out new features!

I'm working on this update for more than 1 year but only yesterday I did have the courage and nerves to build *all* releases until 3.1.4 as a way to understand the best way to "hack= " configures and Makefiles and stuff.

Please give it a try and tell me if anything needs to be fixed, etc.

Cheers!


-- =
Nuno Teixeira
FreeBSD Committer (ports)

Hi Eduardo,

xpaint seems to not be multi-jobs-safe. The build will eventually fail with this:

cd app-defaults ; \
../substads -appdefs \
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 XPAINT_VERSION 3.1.4 \
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 XPAINT_SHAREDIR /usr/local/share/xpaint \
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 XPAINT_PRINT_COMMAND "lp -d" \
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 XPAINT_PRINTER_LIST "lpstat -p | cut -d' ' -f 2" \
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 XPAINT_POSTSCRIPT_VIEWER "evince" \
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 XPAINT_EXTERN_VIEWER "display"
/bin/sh: ../substads: Text file busy
gmake[1]: *** [Makefile:1205: XPaint.ad] Error 126
gmake[1]: *** Waiting for unfinished jobs....
gmake[1]: Leaving directory '/usr/ports/graphics/xpaint/work/xpaint-3.1.4'<= br>

You might want to use MAKE_JOBS_UNSAFE=3Dyes.




--
Nun= o Teixeira
FreeBSD Committer (ports)

That's because it's a race condition :)

See:

[danilo@capeta /usr/ports/graphics/xpaint]$ while : ; do make clean >/dev/null ; make >/dev/null 2>&1 ; if [ $? -ne 0 ] ; then echo 'Failed' ; else echo 'Worked' ; fi ; done
Worked
Worked
Failed
Worked
Worked
Worked
Worked
Worked
Worked
Worked
Worked
Worked
Failed
Worked
Worked
Worked
Worked
Worked
Worked
Worked
Failed
Failed
Worked
Worked
Worked
Worked
Worked



--
Nuno Teixeira
FreeBSD Committer (ports)

Yeah apparently that addresses the problem. But as you are using USES=3Dautoreconf, you need to patch Makefile.am actually.

This change seems to be enough:

-XPaint.ad: app-defaults
+XPaint.ad: substads app-defaults



--
Nuno Teixeira
FreeBSD Committ= er (ports)
--000000000000881a24060076867a--