From nobody Sun Feb 12 23:37:31 2023 X-Original-To: ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PFP5v0hYZz3pgq3 for ; Sun, 12 Feb 2023 23:37:39 +0000 (UTC) (envelope-from fbl@aoek.com) Received: from mail.yourbox.net (mail.yourbox.net [IPv6:2001:41d0:1:767d::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.yourbox.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PFP5t03lgz3J7W; Sun, 12 Feb 2023 23:37:37 +0000 (UTC) (envelope-from fbl@aoek.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=aoek.com header.s=mailbox header.b=lh36MXsl; spf=pass (mx1.freebsd.org: domain of fbl@aoek.com designates 2001:41d0:1:767d::1 as permitted sender) smtp.mailfrom=fbl@aoek.com; dmarc=pass (policy=reject) header.from=aoek.com Received: from mail.yourbox.net (localhost [IPv6:0:0:0:0:0:0:0:1]) by mail.yourbox.net (8.17.1/8.17.1) with ESMTP id 31CNbadE065512; Mon, 13 Feb 2023 00:37:36 +0100 (CET) (envelope-from fbl@aoek.com) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=aoek.com; s=mailbox; t=1676245056; bh=s2TLG3KDXab/0wyflw83oMtIbCL+frWzERopwPG13Rk=; h=Date:From:To:Cc:Subject; b=lh36MXslLSz3wY58AnOnVB7L60RwWt7lZFLovGsUHJUvZ8/ZgSt5hHS38KrTD/5QQ /oF42HZgUFUJuJ8d20gJ78Y9yeyt441iCiA/46eKTnfrV/MOUV+nltqidcEqyTp9jA 3mGYZeO6seEZJyByrfdLsOzlcjgCaamp1/DHMHp2kQiTw2luqS10uv1krsf+fL2KOe R3W9NpJ78FqDLwByaiCx7OWBVb41HaklZDxLa0+B+c6Vxix8m0lUcej+Ag1iFvaUqL KLWsDzWVluTMh1Gylyn1eFJUtzCubzVsfvW+Np9xycMbYKHEw+qmVugzk5c/pnRw8o Cb3fCS95SAKPw== List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Mon, 13 Feb 2023 00:37:31 +0100 From: =?UTF-8?Q?Jos=C3=A9_P=C3=A9rez?= To: ports@freebsd.org Cc: cmt@freebsd.org, tcberner@freebsd.org Subject: [includes patch] print/gimp-gutenprint fails to build on 14.0-CURRENT 1400079 Message-ID: <7c8ba50168308c82e6aeb13da024ef52@mail.yourbox.net> X-Sender: fbl@aoek.com User-Agent: Roundcube Webmail/1.2.0 X-Spamd-Result: default: False [-3.28 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.999]; R_MIXED_CHARSET(0.71)[subject]; DMARC_POLICY_ALLOW(-0.50)[aoek.com,reject]; R_DKIM_ALLOW(-0.20)[aoek.com:s=mailbox]; R_SPF_ALLOW(-0.20)[+mx]; MIME_GOOD(-0.10)[text/plain]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; MLMMJ_DEST(0.00)[ports@freebsd.org]; RCVD_TLS_LAST(0.00)[]; TO_DN_NONE(0.00)[]; ASN(0.00)[asn:16276, ipnet:2001:41d0::/32, country:FR]; ARC_NA(0.00)[]; DKIM_TRACE(0.00)[aoek.com:+]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Queue-Id: 4PFP5t03lgz3J7W X-Spamd-Bar: --- X-ThisMailContainsUnwantedMimeParts: N Hi, I get the following error when poudriere building print/gimp-gutenprint on 14.0-CURRENT 1400079: /usr/local/include/glib-2.0/glib/gmacros.h:1211:44: note: expanded from macro 'G_DEPRECATED_FOR' #define G_DEPRECATED_FOR(f) __attribute__((__deprecated__("Use '" #f "' instead"))) ^ print.c:117:29: error: incompatible pointer to integer conversion passing 'void *' to parameter of type 'gint32' (aka 'int') [-Wint-conversion] gint x = gimp_image_width(image_ID); ^~~~~~~~ /usr/local/include/gimp-2.0/libgimp/gimpimage_pdb.h:49:86: note: passing argument to parameter 'image_ID' here gint gimp_image_width (gint32 image_ID); ^ print.c:118:30: error: incompatible pointer to integer conversion passing 'void *' to parameter of type 'gint32' (aka 'int') [-Wint-conversion] gint y = gimp_image_height(image_ID); ^~~~~~~~ /usr/local/include/gimp-2.0/libgimp/gimpimage_pdb.h:50:86: note: passing argument to parameter 'image_ID' here gint gimp_image_height (gint32 image_ID); ^ print.c:234:14: warning: 'gimp_drawable_get' is deprecated: Use 'gimp_drawable_get_buffer' instead [-Wdeprecated-declarations] drawable = gimp_drawable_get (drawable_ID); ^ /usr/local/include/gimp-2.0/libgimp/gimpdrawable.h:51:1: note: 'gimp_drawable_get' has been explicitly marked deprecated here GIMP_DEPRECATED_FOR(gimp_drawable_get_buffer) ^ /usr/local/include/gimp-2.0/libgimpbase/gimpbasetypes.h:43:32: note: expanded from macro 'GIMP_DEPRECATED_FOR' #define GIMP_DEPRECATED_FOR(f) G_DEPRECATED_FOR(f) ^ /usr/local/include/glib-2.0/glib/gmacros.h:1211:44: note: expanded from macro 'G_DEPRECATED_FOR' #define G_DEPRECATED_FOR(f) __attribute__((__deprecated__("Use '" #f "' instead"))) ^ print.c:254:52: warning: 'gimp_gamma' is deprecated [-Wdeprecated-declarations] stp_set_float_parameter(gimp_vars.v, "AppGamma", gimp_gamma()); ^ /usr/local/include/gimp-2.0/libgimp/gimp.h:347:1: note: 'gimp_gamma' has been explicitly marked deprecated here GIMP_DEPRECATED ^ /usr/local/include/gimp-2.0/libgimpbase/gimpbasetypes.h:42:25: note: expanded from macro 'GIMP_DEPRECATED' #define GIMP_DEPRECATED G_DEPRECATED ^ /usr/local/include/glib-2.0/glib/gmacros.h:1201:37: note: expanded from macro 'G_DEPRECATED' #define G_DEPRECATED __attribute__((__deprecated__)) ^ print.c:514:7: warning: 'gimp_tile_cache_ntiles' is deprecated [-Wdeprecated-declarations] gimp_tile_cache_ntiles ((drawable->height + gimp_tile_width () - 1) / ^ /usr/local/include/gimp-2.0/libgimp/gimptile.h:59:1: note: 'gimp_tile_cache_ntiles' has been explicitly marked deprecated here GIMP_DEPRECATED ^ /usr/local/include/gimp-2.0/libgimpbase/gimpbasetypes.h:42:25: note: expanded from macro 'GIMP_DEPRECATED' #define GIMP_DEPRECATED G_DEPRECATED ^ /usr/local/include/glib-2.0/glib/gmacros.h:1201:37: note: expanded from macro 'G_DEPRECATED' #define G_DEPRECATED __attribute__((__deprecated__)) ^ print.c:517:7: warning: 'gimp_tile_cache_ntiles' is deprecated [-Wdeprecated-declarations] gimp_tile_cache_ntiles ((drawable->width + gimp_tile_width () - 1) / ^ /usr/local/include/gimp-2.0/libgimp/gimptile.h:59:1: note: 'gimp_tile_cache_ntiles' has been explicitly marked deprecated here GIMP_DEPRECATED ^ /usr/local/include/gimp-2.0/libgimpbase/gimpbasetypes.h:42:25: note: expanded from macro 'GIMP_DEPRECATED' #define GIMP_DEPRECATED G_DEPRECATED ^ /usr/local/include/glib-2.0/glib/gmacros.h:1201:37: note: expanded from macro 'G_DEPRECATED' #define G_DEPRECATED __attribute__((__deprecated__)) ^ print.c:539:3: warning: 'gimp_drawable_detach' is deprecated [-Wdeprecated-declarations] gimp_drawable_detach (drawable); ^ /usr/local/include/gimp-2.0/libgimp/gimpdrawable.h:53:1: note: 'gimp_drawable_detach' has been explicitly marked deprecated here GIMP_DEPRECATED ^ /usr/local/include/gimp-2.0/libgimpbase/gimpbasetypes.h:42:25: note: expanded from macro 'GIMP_DEPRECATED' #define GIMP_DEPRECATED G_DEPRECATED ^ /usr/local/include/glib-2.0/glib/gmacros.h:1201:37: note: expanded from macro 'G_DEPRECATED' #define G_DEPRECATED __attribute__((__deprecated__)) ^ 7 warnings and 2 errors generated. gmake[1]: *** [Makefile:549: print.o] Error 1 gmake[1]: Leaving directory '/wrkdirs/usr/ports/print/gimp-gutenprint/work/gutenprint-5.3.3/src/gimp2' *** Error code 1 Stop. make: stopped in /usr/ports/print/gimp-gutenprint I fixed with this patch: --- src/gimp2/print.c.orig 2023-02-13 00:19:26.381303000 +0100 +++ src/gimp2/print.c 2023-02-13 00:20:10.617649000 +0100 @@ -114,8 +114,8 @@ { if (gimp_thumbnail_data) g_free(gimp_thumbnail_data); - gint x = gimp_image_width(image_ID); - gint y = gimp_image_height(image_ID); + gint x = gimp_image_width(p2gint(image_ID)); + gint y = gimp_image_height(p2gint(image_ID)); if (*width > x) *width = x; if (*height > y) This is a bug that gets triggered by the use of llvm 15 and I think should be pushed upstream. Anyone with upstream contacts? BR, -- José Pérez