Re: plist-check not reporting orphaned files present in a @comment

* Tatsuki Makino <tatsuki_makino@hotmail.com> [20230817 07:57]:
> Switching @comment by ${ARCH} is also in print/epson-inkjet-printer-escpr2.
> This is not a problem with check-orphans.

It is, when some file doesn't exist for all architectures, but for more
than one of them.

You first test the port on ARCH=foo. Then you test on ARCH=bar and find
that it builds/installs an additional tmp/something, so you prefix it
with %%BAR%% which expands to "@comment " unless building on ARCH=bar.

Then you test on ARCH=baz which happens to build/install the same
tmp/something. plist-check will still be happy because the file is there
in pkg-plist (ignoring the @comment). Still, the file will be missing
from the package.

I might try another workaround, e.g. expand to "@comment dummy/"
instead, so the name won't match and plist-check will complain ...

> However, linuxulator ports often switch plist file itself for different ${ARCH}.

Sure, but that's only suitable when a large portion of entries is indeed
different depending on ${ARCH}.

-- 
 Felix Palmen <zirias@FreeBSD.org>     {private}   felix@palmen-it.de
 -- ports committer --                     {web}  http://palmen-it.de
 {pgp public key}  http://palmen-it.de/pub.txt
 {pgp fingerprint} 6936 13D5 5BBF 4837 B212  3ACC 54AD E006 9879 F231