From nobody Tue Apr 18 13:38:58 2023 X-Original-To: ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q14lL5vKSz4575R for ; Tue, 18 Apr 2023 13:39:10 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q14lL5LqDz4MTH; Tue, 18 Apr 2023 13:39:10 +0000 (UTC) (envelope-from eduardo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681825150; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+9plEj2T+GbLqGz0Qy5M8RAiLC2YBTMAItzuzjk65ko=; b=NvE83nRvTRc7/Hd6BGpkStSH8PG3HOgqq3lDzqfoa2iXq23qEoWD+Ke1O/RbpFacuU9bvC RoQH6sPxJ0Eqp32w1APKirwDhkWrLs/pcdJDhyGQd2s06WBlaZn+XeKBeMnqDVlgkl4meO cTb8e6dFyxJ8HsIYXWd9lA1mN4qDdOyTFZ+xBQZaumfVC4s5+i7Rzzs/2vY5tPwqf2cfEQ vUGwgNPuZT2QU49k0AHVvhPytZRSB+qOu7xxqeWHpbQjUvmNfjK8p7mXoFShZbuG+cFut3 zXjDKwSbtGgsL6lHYojOMzULGMKUfszrCM4LlCanjxTp2PYYDHdixC0lTux4wA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681825150; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+9plEj2T+GbLqGz0Qy5M8RAiLC2YBTMAItzuzjk65ko=; b=hdeHt4hh33zVYKtEK92xH+b3wYot2xjMgV4BCF5npuGOYsjl7TEF3Xe/9dQaRTHb8btbjD PjqOUmvHOtZ3c1gz4ME7GPeFeiKdC4CHhK7uJ/lPTQjj3oBfbhvixzJI0nq5s6HJJcQgnI N6k8IGI480XIzbzJ36VpX67+HNHnKV0ymQ5+4KUqeIuzoyjPhByl2VN1CQ7gKCopCmJQig zw3fFrr6c2H68reZJCWsfSpPk67UX7bGgCTHgexmt0LYR95MxvCWIodLZCtaRgcCyJK1B1 vySnpqD8IZDEcKP/7iIof4/JHrDuTNcQQyDjlJTUGQXvQikTAR2JNKiRBPpGmw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1681825150; a=rsa-sha256; cv=none; b=OoBF1LZlnYC9fk8oXSbLu+4aTQGjP6/FGxnDkGVf6Wi5f7sDnKkqPKHY4hcHw9jCSSBt1T ZyC2fZvWVYaARxYOWBsZFFmsH9Z2cXpN63Ks0Paumt3bAXvRK4C5KvTsJOVXzvwo/PQ2hm dwjvnIF9MYOeOl8p+/u+ztrXa8/x1bqXSKs7UFsnz6+H3kfwgriYOzdFMrBae5N2h1h7yP HX1dvJ0SrAHWy7dHhlbYOjDO7LGMDO8ivrxehkY1m7JzubTBFAoMoe/9ZYMaKg+ENRBWy/ g1ewlQWZ6Rc7QUbs3VHJ+WS+zz+chWfkP1t4/my0PPA2RDnoAlTEHlMNs65yYQ== Received: from mail-ua1-f53.google.com (mail-ua1-f53.google.com [209.85.222.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: eduardo) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Q14lL3wf7z14nK; Tue, 18 Apr 2023 13:39:10 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: by mail-ua1-f53.google.com with SMTP id a19so5095834uan.1; Tue, 18 Apr 2023 06:39:10 -0700 (PDT) X-Gm-Message-State: AAQBX9e4K8ymNSXS61Ok4nP040qQL+x/C1O3zp06CRs1fsFWcp+t902s cfNvzYfCRZuSGicNqzWY2ar8Bt4Pg53bwk94/LY= X-Google-Smtp-Source: AKy350a/spItDqNqW96qFKPk1VrR0lfzdUIZ7eJMDuAmcHhZvRnooews/uoOiyt2RHm488yvrum/Ccjs9JDd4PXHrDE= X-Received: by 2002:a1f:2a47:0:b0:43f:c93f:4eb8 with SMTP id q68-20020a1f2a47000000b0043fc93f4eb8mr10708000vkq.3.1681825149823; Tue, 18 Apr 2023 06:39:09 -0700 (PDT) List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org MIME-Version: 1.0 References: <3gizlmiaz2h3qwk6xe64iik42vr6mtxyex4d2hjaymazz5nngt@3wm6jdrdxslm> <2su26bpfemilo52atij5i2focesm4iejrkrjry5dr7w4xlxe55@5rjqkjv3tzyk> In-Reply-To: From: Nuno Teixeira Date: Tue, 18 Apr 2023 14:38:58 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Get ${OSREL} at install time To: Felix Palmen Cc: ports@freebsd.org Content-Type: multipart/alternative; boundary="000000000000a1331d05f99c6eb8" X-ThisMailContainsUnwantedMimeParts: N --000000000000a1331d05f99c6eb8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Ok, I will continue testing. BTW, I've openned a PR at https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D270911 Please test :) Thanks all Felix Palmen escreveu no dia ter=C3=A7a, 18/04/2023 = =C3=A0(s) 14:13: > * Nuno Teixeira [20230418 13:45]: > > I will do further tests and open an PR so other people try it (I hope). > > I would suggest a final improvement: You should probably sanity-check > what you get from freebsd-version (and in case it isn't sane, stick to > the compile-time defaults). That's because it's perfectly possible to > install packages with "pkg -r" into a prefix that doesn't even have base > installed (so, also no freebsd-version available there). > > -- > Felix Palmen {private} felix@palmen-it.de > -- ports committer (mentee) -- {web} http://palmen-it.de > {pgp public key} http://palmen-it.de/pub.txt > {pgp fingerprint} 6936 13D5 5BBF 4837 B212 3ACC 54AD E006 9879 F231 > --=20 Nuno Teixeira FreeBSD Committer (ports) --000000000000a1331d05f99c6eb8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Ok, I will continue testing.

BTW, I've openned a PR at https://bugs.freebsd.org/bugzilla/show_bug.cgi?i= d=3D270911

Please test :)

=
Thanks all

Felix Palmen <zirias@freebsd.org> escreveu no dia ter=C3=A7a, 18/04/2023 =C3= =A0(s) 14:13:
* = Nuno Teixeira <= eduardo@freebsd.org> [20230418 13:45]:
> I will do further tests and open an PR so other people try it (I hope)= .

I would suggest a final improvement: You should probably sanity-check
what you get from freebsd-version (and in case it isn't sane, stick to<= br> the compile-time defaults). That's because it's perfectly possible = to
install packages with "pkg -r" into a prefix that doesn't eve= n have base
installed (so, also no freebsd-version available there).

--
=C2=A0Felix Palmen <zirias@FreeBSD.org>=C2=A0 =C2=A0 =C2=A0{private}= =C2=A0 =C2=A0felix@= palmen-it.de
=C2=A0-- ports committer (mentee) --=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 {web}=C2=A0 http://palmen-it.de
=C2=A0{pgp public key}=C2=A0 http://palmen-it.de/pub.txt
=C2=A0{pgp fingerprint} 6936 13D5 5BBF 4837 B212=C2=A0 3ACC 54AD E006 9879 = F231


--
Nuno Teixeira
FreeBSD Committ= er (ports)
--000000000000a1331d05f99c6eb8--