[Bug 294141] x11/sfwbar: Update 1.0_beta16.1 => 1.0_beta17

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=294141

Daniel Engberg <diizzy@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |diizzy@FreeBSD.org

--- Comment #3 from Daniel Engberg <diizzy@FreeBSD.org> ---
Overall review and suggestions

Regarding, PKGNAMESUFFIX
Just follow example 99,
https://docs.freebsd.org/en/books/porters-handbook/book/#flavors-using

Missing definition,
FLAVOR?=        ${FLAVORS:[1]}
https://docs.freebsd.org/en/books/porters-handbook/book/#flavors-using

.if ${FLAVOR:U:M*nopulse}
OPTIONS_EXCLUDE+=       PIPEWIRE PULSEAUDIO
...

There's no need for complex logic that's never evaluated, there are only two
flavours. See https://docs.freebsd.org/en/books/porters-handbook/book/#flavors
(example 100) and OPTIONS_EXCLUDE+= --> OPTIONS_EXCLUDE=

.include <bsd.port.options.mk> should be used instead of pre.mk and post.mk
https://docs.freebsd.org/en/books/porters-handbook/book/#options_sub

I would argue that flavour should only disable pulseaudio, otherwise call it
lite

Remove all patches since they're now included in new version -->
Drop backported patches as they're in new release

Best regards,
Daniel

-- 
You are receiving this mail because:
You are the assignee for the bug.