[Bug 294122] [new port] www/MoonGem: Gemini protocol server with lua scripting suppor

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=294122

--- Comment #2 from Daniel Engberg <diizzy@FreeBSD.org> ---
Port Makefile looks pretty good but there are a few things that can be
improved, 

Please only use lowercase for PORTNAME and all other references to it, MoonGem
--> moongem

LIB_DEPENDS referring to devel/p5-File-LibMagic looks incorrect as you're
probably looking for libmagic in base? If so, you don't need to define
dependency in LIB_DEPENDS.

Use PORTNAME/binary name for rc.d script

Change do-build-MANPAGES-on to post-build-MANPAGES-on
Use full filename instead of ALL_TARGET
Add ${LOCALBASE} to scdoc path

In USE_RC_SUBR remove reference to variable, just use the filename directly

post-extract occurrs before *-build and so that section should be placed above

Remove for loop in post-install-MANPAGES-on, you only need two lines

"And then update the placerholders inside the OpenRC script." 
rc.d isn't OpenRC and after install you as a user / consumer shouldn't need to
adjust it. If variables needs to be changed it should be done via rc.conf using
one or several variables which in turn are utilzied by the rc.d script

Best regards,
Daniel

-- 
You are receiving this mail because:
You are the assignee for the bug.