[Bug 295274] lang/swipl: update to 10.0.2

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=295274

--- Comment #23 from Robert Clausecker <fuz@FreeBSD.org> ---
(In reply to Nikolaj Thygesen from comment #22)

Thanks!

Do you have a changelog for this update?
Could you provide a more detailed BROKEN_i386 reason?
We usually do not touch CMAKE_BUILD_TYPE, as USES=cmake sets it correctly.
If you must set it, do so through the CMAKE_BUILD_TYPE variable instead of
going through CMAKE_ARGS.  Please make sure that a debug build is selected if
make variable WITH_DEBUG is set.
In particular, further down in the same file, CMAKE_BUILD_TYPE=Release is
provided, contradicting your earlier assignment?!
Read Mk/Uses/cmake.mk for details.

Instead of DOCS_CMAKE_ON and DOCS_CMAKE_OFF use
DOCS_CMAKE_BOOL=INSTALL_DOCUMENTATION if possible.

See if you can hook up the unit tests to "make test".
Often it suffices to do USES=cmake:testing.
Refer to Porter's Handbook for details.

It looks a lot like libunwind is a dependency on all platforms.
Perhaps make the dependency unconditional to simplify the Makefile.
You should then be able to avoid including <bsd.port.pre.mk>.

Please remove the post-patch block and replace the substitutions by patch files
as per policy (REINPLACE_CMD is only for dynamic replacements).

The rest looks reasonable.
Please address these issues so I can do another build test.
For submitting the next patch, I recommend squashing your changes into one
patch before submission (using git rebase -i).

-- 
You are receiving this mail because:
You are the assignee for the bug.