[Bug 295726] do-fetch skipping fetch based on filename without further validation

From: <bugzilla-noreply_at_freebsd.org>
Date: Mon, 15 Jun 2026 19:36:22 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=295726

--- Comment #14 from Benjamin Takacs <nimaje+fbz@bureaucracy.de> ---
(In reply to Mathieu Arnold from comment #11)
I think the disagreement is what make fetch/checksum should do.

I think  make fetch  should fetch the wanted file and  make checksum  should
verify the *just fetched* file, I don't think it should be the job of  make
checksum  to refetch the file *after*  make fetch  skipped the fetching because
the distcache contains a file with the same name as the wanted file. I don't
even think  make checksum  should do any fetching, but in case of transient
network problems it might be ok.

As the distcache is a cache, I don't think it is ok for  make fetch  to skip
doing its job of fetching the wanted files, when it didn't properly checked
that the cached file is indeed the wanted file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.