[Bug 292220] security/tailscale: refactor rc script to respect rc.subr variables

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=292220

            Bug ID: 292220
           Summary: security/tailscale: refactor rc script to respect
                    rc.subr variables
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Many People
          Priority: ---
         Component: Individual Port(s)
          Assignee: ashish@FreeBSD.org
          Reporter: ross@ross-williams.net
             Flags: maintainer-feedback?(ashish@FreeBSD.org)
          Assignee: ashish@FreeBSD.org

Created attachment 266872
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=266872&action=edit
Patch to security/tailscale/files/tailscaled.in

security/tailscale's rc script specifies a custom start_cmd. This prevents
rc.subr's default start command "builder" logic from running. Bypassing
rc.subr's default logic causes many of the documented rc.conf variables such as
${name}_nice and ${name}_oomprotect to not work.

All of the logic in the current start_cmd can be handled by a start_precmd, and
the invocation of /usr/sbin/daemon can be handled using the command and
command_args variables, as it is done in many other ports' rc scripts.
Refactoring tailscale's rc script this way allows all the rc.subr-documented
${name}_* variables to function as expected, and does not alter anything about
the way the current rc script invokes tailscaled.

Patch attached.

-- 
You are receiving this mail because:
You are the assignee for the bug.