[Bug 293508] emulators/mame: Update to 0.286

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=293508

--- Comment #2 from Laurent Chardon <laurent.chardon@gmail.com> ---
Hello Vlad,

Thanks for the review. Would you mind explaining how the sorting is incorrect?
I thought that I was allowed to sort this way.

From the porter's handbook:

"It is recommended to keep all the filenames in this file sorted
alphabetically. It will make verifying changes when upgrading the port much
easier. The sorting should be applied after variable expansion takes place. The
framework does this correctly when the package list is generated
automatically".

This seems to be a recommendation, not a mandatory port requirement. The
difficulty I have is to sort *after the variable expansion*. Is there a tool to
do it? I tried plist-sort from ports-mgmt/ports-tools but it ate the %% around
%%MAMEDATA%%, so I stopped trusting it, as I don't know what other things it
might not be doing well, and it's too easy to miss single instances of
incorrect variable naming. I also can't use "make makeplist" because of the
port options that are not handled by that method. So the alternatives are
sorting before variable expansion, which is what I did, or sorting manually.
I'll be honest, I prefer not to sort manually if I don't have to.

In the end, the goal is to make verifying changes easier. Sorting before
variable expansion achieves this goal.

Your thoughts?

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.