[Bug 293393] comms/bladerf: fix build with clang 21

From: <bugzilla-noreply_at_freebsd.org>
Date: Mon, 23 Feb 2026 21:02:39 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=293393

            Bug ID: 293393
           Summary: comms/bladerf: fix build with clang 21
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: yuri@freebsd.org
          Reporter: dim@FreeBSD.org
             Flags: maintainer-feedback?(yuri@freebsd.org)
          Assignee: yuri@freebsd.org

With clang 21 comms/bladerf fails to build, with errors similar to:

   
/wrkdirs/usr/ports/comms/bladerf/work/bladeRF-2025.10/host/utilities/bladeRF-cli/src/cmd/flash_image.c:71:35:
error: overlapping comparisons always evaluate to true
[-Werror,-Wtautological-overlap-compare]
       71 |                 if (val[i] >= 'a' || val[i] <= 'f') {
          |                     ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~

This is a logic error: the logical operator should be `&&` here. It has
been proposed as an upstream pull request:
https://github.com/Nuand/bladeRF/pull/1045, but it is not yet merged.

-- 
You are receiving this mail because:
You are the assignee for the bug.