[Bug 292346] [NEW PORT] emulators/fab-agon-emulator: Emulator for Agon Light computer

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=292346

Robert Clausecker <fuz@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fuz@FreeBSD.org

--- Comment #8 from Robert Clausecker <fuz@FreeBSD.org> ---
Thank you for your submission, here are some items to check:

 - ensure your maintainer email address matches the address you signed up on
   Bugzilla with so that bug reports get assigned to you correctly.
 - USE_SDL without USES=sdl is nonsensical, either add USES=sdl or remove
USE_SDL.
 - why does the port depend on the C++ library from gcc?  We have libc++.so
   in base and that's what ports are supposed to use unless they compile with
gcc.
   You don't compile with gcc, so this is weird.  Perhaps patch the build so it
   pulls libc++ from base instead of trying to link against gcc's library.
 - GH_PROJECT can and should be omitted if it matches PORTNAME.
 - GH_TAGNAME can and should be omitted if it matches ${DISTVERSION}
 - prefer DISTVERSION over PORTVERSION
 - if you have rust components, it's a good idea to let our framework build
them
   instead of having the port's makefile do it, as we pass a bunch of custom
   options.  See e.g. media/ccextractor for an example.  The basic scheme is

        ${CARGO_CARGO_RUN} build \
                --manifest-path ${CARGO_CARGOTOML} \
                --verbose \
                --verbose \
                ${CARGO_BUILD_ARGS}

 - instead of patching a custom installation routine into the Makefile,
   just write a do-install target that installs the files into the right
places.
 - please use INSTALL_PROGRAM, INSTALL_DATA, and so on for the appropriate type
of
   file instead of calling BSD_INSTALL_PROGRAM.  This ensures the right flags
are
   passed and that the right permissions are set.
 - I recommend you keep patches as small as possible to avoid merge conflicts.
   For example, you don't need to delete the check target, it suffices to
remove it
   as a dependency.
 - if there is a test suite, check if you can hook it into TEST_TARGET or
do-test

-- 
You are receiving this mail because:
You are the assignee for the bug.