[Bug 289292] [NEW PORT] benchmarks/py-reframe: HPC system validation & performance regression framework

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289292

Robert Clausecker <fuz@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fuz@FreeBSD.org

--- Comment #5 from Robert Clausecker <fuz@FreeBSD.org> ---
Thank you for your submission.  Here are some items to check:

 - can this port be fetched from PYPI instead of github?  This is the preferred
   source for Python ports.
 - if possible harmonise the port name with what PYPI gives
 - instead of rolling custom targets, does this port build with one of the
standard
   mechanisms (USE_PYTHON=distutils or USE_PYTHON=pep517)?
 - if no build is required, set NO_BUILD=yes instead of providing an empty
do-build
 - do not hide build commands with @ signs
 - why is the installation of the shell completions conditional?  Ports must
always
   install exactly those files listed in pkg-plist, you can't conditionally
install
   files (unless you define options)
 - this needs "USE_PYTHON=flavors concurrent" most likely
 - please remove WWW from pkg-descr, this field has been superseeded by the WWW
   variable in the Makefile

Rest looks fine, though I have not yet done a build test.

-- 
You are receiving this mail because:
You are the assignee for the bug.