[Bug 297886] emulators/ares wrong BUILD_DEPENDS

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=297886

Stefan Schlosser <bsdcode@disroot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #274122|0                           |1
        is obsolete|                            |
 Attachment #274202|                            |maintainer-approval+
              Flags|                            |

--- Comment #10 from Stefan Schlosser <bsdcode@disroot.org> ---
Created attachment 274202
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=274202&action=edit
Remove librashader from BUILD_DEPENDS

I looked into splitting the librashader port and provide a headers-only port. I
knew that splitting ports in such way is not common on FreeBSD like the -dev
and -lib split often seen in Linux repositories. But I'm actually surprised to
see how uncommon it really is. An examination of the `pkg search header`
results shows that there's only one true header-split: net/avahi-header

Additionally, the librashader split would become awkward because we also have
to decide where to put the librashader.pc PkgConfig file. I'd put it into the
header port because if a program tries to find librashader via PkgConfig it
would only need the header port and not the library port which in turn would
require Rust again.

All in all, I would refrain from splitting the librashader port now. From the
perspective of a FreeBSD port with proper dependency unbundling, the mandatory
BUILD_DEPENDS= librashader is correct.

As a convenience for a (presumably) small number of users who don't want the
shader support and also don't want to have to build Rust in this case, I throw
my previous patch back in the ring. Just use the bundled headers if the
LIBRASHADER option is disabled.
I removed the additional cosmetic changes I had in the previous patch. These
are better served with a separate PR to keep this PR focused.

-- 
You are receiving this mail because:
You are the assignee for the bug.